CODEWITHSUNDEEP
phphtml
EdzJohnson
EdzJohnson

Reputation: 1165

Automatic hyperlink adding an extra HTTP:// to the beginning?

I've the following script which hyperlinks any links posted on my site:

    $text = trim($text);
    while ($text != stripslashes($text)) { $text = stripslashes($text); }    
    $text = strip_tags($text,"<b><i><u>");
    $text = preg_replace("/(?<!http:\/\/)www\./","http://www.",$text);
    $text = preg_replace( "/((http|ftp)+(s)?:\/\/[^<>\s]+)/i", "<a href=\"\\0\" target=\"_new\">\\0</a>",$text);

However, for some reason if I add a https://www.test.com link it ends up displaying like this - https://http://www.test.com - what am I doing wrong? How can I make it work with https links as well? It works fine with http links. Thank you! :-)

Upvotes: 0

Views: 176

Answers (1)

newfurniturey
newfurniturey

Reputation: 38416

The lookbehind that you have here, (?<!http:\/\/)www\. is only matching http://, but your test input (that's failing) is https://.

You can add a second lookbehind chained with the current one to specify the alternative https:// version too:

(?<!http:\/\/)(?<!https:\/\/)www\.

This would make your full line look like:

$text = preg_replace("/(?<!http:\/\/)(?<!https:\/\/)www\./","http://www.",$text);

The last I checked, PHP does not support variable-length lookbehinds, so things that may be familiar such as http[s]?:// wouldn't work here - hence the second pattern.

Upvotes: 1

Related Questions