CODEWITHSUNDEEP
androidlayoutfragmentdimension
lory105
lory105

Reputation: 6302

Android get layout height and width in a fragment

I am working on a fragment and I want to get the dimension of a layout contained in the xml fragment layout. When I try the code 

RelativeLayout myLayout = view.findViewById(R.id.myLayout);
myLayout.getHeight();

it returns 0. I need these dimensions to put inside myLayout other objects.

I try to use:

myLayout.getViewTreeObserver().addOnGlobalLayoutListener( 
    new ViewTreeObserver.OnGlobalLayoutListener(){

        @Override
        public void onGlobalLayout() {
            mHeight = myLayout.getHeight();  
            mWidth= myLayout.getWidth();
            System.out.println("width: "+mWidth+"   height: "+mHeight);
         }
});

but this code is invoke a lot of time and I don't know exactly when it is execute. I need these dimensions into public void onActivityCreated () method. Is it possible?

Upvotes: 22

Views: 35664

Answers (3)

Staffan
Staffan

Reputation: 939

There's a cleaner solution to this, just use the View.post() method on your fragment's root view, and you can call getMeasuredHeight()/getMeasuredWidth() and get the actual values.

E.g.

public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
    View root = inflater.inflate(R.layout.myfragment, container, false);

    root.post(new Runnable() {
        @Override
        public void run() {
            // for instance
            int height = root.getMeasuredHeight(); 
        }
    });

    return root;
}

Very neat and tidy and no messy mucking about with the ViewTreeObserver.

I've only tested this with android-23 devices, but the API has had this method since level 1.

Anyway, WFM.

Upvotes: 38

Udi Oshi
Udi Oshi

Reputation: 6867

The addOnGlobalLayoutListener will be called whenever small change of the view happened. So you need to remove this listener from the view.

Simple usage: 

public static void removeOnGlobalLayoutListener(View v, ViewTreeObserver.OnGlobalLayoutListener listener){
if (Build.VERSION.SDK_INT < 16) {
    v.getViewTreeObserver().removeGlobalOnLayoutListener(listener);
} else {
    v.getViewTreeObserver().removeOnGlobalLayoutListener(listener);
}

}

I would suggest you to check :

if (myLayout.getHeight()>0 && myLayout.getWidth()>0) {
// Do some code...
removeOnGlobalLayoutListener(..)
}

Upvotes: 11

Bradley Campbell
Bradley Campbell

Reputation: 9808

In onActivityCreated, the view hasn't been measured yet.

So no, you can't get the measurements from there. onGlobalLayout is a good place to do it. Layouts happen directly after measurement.

You can remove your listener afterwards, if you only want to do it once. Note that layouts can change size though (soft keyboards appearing, for example)

Upvotes: 2

Related Questions