CODEWITHSUNDEEP
asp.netasp.net-mvcasp.net-mvc-4razor-2
jtlowe
jtlowe

Reputation: 857

Why is ASP.NET View Engine checking for .Mobile.chstml view path?

For my ASP.NET MVC 4 project, I'm trying to implement a custom view engine to find an "Index.cshtml" view file if one exists within a folder. Additionally, I'm throwing a 404 for all view paths that are not found.

The 404 works when a view file doesn't exist. When a view file does exist, the view engine will then try looking for a .Mobile.cshtml file using the FileExists() function. There is no .mobile.cshtml file, so it throws an exception. Why does the view engine still look for a .mobile.cshtml file when it has found the non-mobile file already?

For example, when the view engine is able to find a view path at "~/Views/About/History/Index.cshtml", it will then try finding the file "~/Views/About/History/Index.Mobile.cshtml". Below is my full code for the custom view engine.

namespace System.Web.Mvc
{
  // Extend where RazorViewEngine looks for view files.
  // This looks for path/index.ext file if no path.ext file is found
  // Ex:  looks for "about/history/index.chstml" if "about/history.cshtml" is not found.
  public class CustomViewEngine : RazorViewEngine
  {
    public BeckmanViewEngine()
    {
      AreaViewLocationFormats = new[] 
      {
        "~/Areas/{2}/Views/{1}/{0}/Index.cshtml",
      };

      ViewLocationFormats = new[] 
      {
        "~/Views/{1}/{0}/Index.cshtml",
      };
    }

    // Return 404 Exception if viewpath file in existing path is not found
    protected override bool FileExists(ControllerContext context, string path)
    {
      if (!base.FileExists(context, path))
      {
        throw new HttpException(404, "HTTP/1.1 404 Not Found");
      }

      return true;
    }
  }
}

Upvotes: 2

Views: 1476

Answers (2)

Huske
Huske

Reputation: 9296

Have you tried removing Mobile DisplayModeProvider. You can achieve this by running the following in Application_Start:

var mobileDisplayMode = DisplayModeProvider.Instance.Modes.FirstOrDefault(a => a.DisplayModeId == "Mobile");

if (mobileDisplayMode != null)
{
    DisplayModeProvider.Instance.Modes.Remove(mobileDisplayMode);
}

THe problem that you are getting is an expected behavior because FindView method queries DisplayModeProvider.

Upvotes: 2

Daniel J.G.
Daniel J.G.

Reputation: 34992

I have found the answer after digging a bit in the MVC 4 source code.

The RazorViewEngine derives from BuildManagerViewEngine, and this one in turns derives from VirtualPathProviderViewEngine. It is VirtualPathProviderViewEngine the one that implements the method FindView:

    public virtual ViewEngineResult FindView(ControllerContext controllerContext, string viewName, string masterName, bool useCache)
    {
        if (controllerContext == null)
        {
            throw new ArgumentNullException("controllerContext");
        }
        if (String.IsNullOrEmpty(viewName))
        {
            throw new ArgumentException(MvcResources.Common_NullOrEmpty, "viewName");
        }

        string[] viewLocationsSearched;
        string[] masterLocationsSearched;

        string controllerName = controllerContext.RouteData.GetRequiredString("controller");
        string viewPath = GetPath(controllerContext, ViewLocationFormats, AreaViewLocationFormats, "ViewLocationFormats", viewName, controllerName, CacheKeyPrefixView, useCache, out viewLocationsSearched);
        string masterPath = GetPath(controllerContext, MasterLocationFormats, AreaMasterLocationFormats, "MasterLocationFormats", masterName, controllerName, CacheKeyPrefixMaster, useCache, out masterLocationsSearched);

        if (String.IsNullOrEmpty(viewPath) || (String.IsNullOrEmpty(masterPath) && !String.IsNullOrEmpty(masterName)))
        {
            return new ViewEngineResult(viewLocationsSearched.Union(masterLocationsSearched));
        }

        return new ViewEngineResult(CreateView(controllerContext, viewPath, masterPath), this);
    }

That GetPath method used there will do something like this when the view path has not been cached yet:

return nameRepresentsPath
           ? GetPathFromSpecificName(controllerContext, name, cacheKey, ref searchedLocations)
           : GetPathFromGeneralName(controllerContext, viewLocations, name, controllerName, areaName, cacheKey, ref searchedLocations);

Getting there! The interesting method is GetPathFromGeneralName, which is the one trying to build the whole path for the view and checking if that path exists. The method is looping through each of the view locations that were registered in the View Engine, updating the view path with the display mode valid for current HttpContext and then checking if the resolved path exists. If so, the view has been found, is assigned to the result, cached and the result path returned.

private string GetPathFromGeneralName(ControllerContext controllerContext, List<ViewLocation> locations, string name, string controllerName, string areaName, string cacheKey, ref string[] searchedLocations)
{
    string result = String.Empty;
    searchedLocations = new string[locations.Count];

    for (int i = 0; i < locations.Count; i++)
    {
        ViewLocation location = locations[i];
        string virtualPath = location.Format(name, controllerName, areaName);
        DisplayInfo virtualPathDisplayInfo = DisplayModeProvider.GetDisplayInfoForVirtualPath(virtualPath, controllerContext.HttpContext, path => FileExists(controllerContext, path), controllerContext.DisplayMode);

        if (virtualPathDisplayInfo != null)
        {
            string resolvedVirtualPath = virtualPathDisplayInfo.FilePath;

            searchedLocations = _emptyLocations;
            result = resolvedVirtualPath;
            ViewLocationCache.InsertViewLocation(controllerContext.HttpContext, AppendDisplayModeToCacheKey(cacheKey, virtualPathDisplayInfo.DisplayMode.DisplayModeId), result);

            if (controllerContext.DisplayMode == null)
            {
                    controllerContext.DisplayMode = virtualPathDisplayInfo.DisplayMode;
            }

            // Populate the cache for all other display modes. We want to cache both file system hits and misses so that we can distinguish
            // in future requests whether a file's status was evicted from the cache (null value) or if the file doesn't exist (empty string).
            IEnumerable<IDisplayMode> allDisplayModes = DisplayModeProvider.Modes;
            foreach (IDisplayMode displayMode in allDisplayModes)
            {
                if (displayMode.DisplayModeId != virtualPathDisplayInfo.DisplayMode.DisplayModeId)
                {
                    DisplayInfo displayInfoToCache = displayMode.GetDisplayInfo(controllerContext.HttpContext, virtualPath, virtualPathExists: path => FileExists(controllerContext, path));

                    string cacheValue = String.Empty;
                    if (displayInfoToCache != null && displayInfoToCache.FilePath != null)
                    {
                        cacheValue = displayInfoToCache.FilePath;
                    }
                    ViewLocationCache.InsertViewLocation(controllerContext.HttpContext, AppendDisplayModeToCacheKey(cacheKey, displayMode.DisplayModeId), cacheValue);
                }
            }
            break;
        }

        searchedLocations[i] = virtualPath;
    }

    return result;
}

You may have noticed that I haven´t talked about a piece of code with the following comment (reformatted for clarity):

// Populate the cache for all other display modes. 
// We want to cache both file system hits and misses so that we can distinguish
// in future requests whether a file's status was evicted from the cache 
// (null value) or if the file doesn't exist (empty string).

That (and the piece of code below the comment :)) means that once MVC 4 has found the first valid path from the View Locations registered in the View Engine, it will also check if the view file for all of the additional display modes that were not tested exist, so that information can be included in the cache (although just for that view location and not all of the locations available in the view engine). Notice also, how it is passing a lambda to each of the tested display modes for checking if the file for that mode exists:

DisplayInfo displayInfoToCache = displayMode.GetDisplayInfo(
                      controllerContext.HttpContext, 
                      virtualPath, 
                      virtualPathExists: path => FileExists(controllerContext, path));

So that explains why when you override FileExists it is also being called for the mobile view, even when it has already found the non-mobile view.

In any case, display modes can be removed the same way they can be added: by updating the DisplayModes collection when the application starts. For example, removing the Mobile display mode and leaving just the default and unspecific one (You cannot clear the collection or no view will ever be found):

...
using System.Web.WebPages;
...

protected void Application_Start()
{
    DisplayModeProvider.Instance.Modes.Remove(
              DisplayModeProvider.Instance.Modes
                                 .Single(m => m.DisplayModeId == "Mobile"));

Quite a long answer but hopefully it makes sense!

Upvotes: 4

Related Questions