CODEWITHSUNDEEP
phpcodeigniter
Ricky Mason
Ricky Mason

Reputation: 1828

if statement running regardless of true false

I have tested each method individually with default values and it all seems to work. There is something going on when they are all mixed together.

Here is the code and i'll do my best to write it in an easy to follow way:

Starting with the controller:

if ($active['newcliq']) 
            {   
                $newcliqid = $this->create_m->create_keyword($cliq, $cliqid);
                if (!$newcliqid) {
                echo json_encode(array('success' => false));
                } else {
                    $this->logic_m->change_active($newcliqid, $cliq);
                }
            }

$active['newcliq'] is true or false and pulled from userdata('active')

Of course, the next thing it runs is create_keyword($cliq, $cliqid) seen below:

$this->db->insert('cliq', $insert); 
            $newcliqid = $this->db->insert_id();
            if ($newcliqid) {
                return $newcliqid;
            } else {
                return false;
            }

Again, I have checked it all manually, and I know that $newcliqid is returning the correct insert_id and the overall function is returning the correct value.

So $newcliqid is returned to the controller and goes runs logic_m->change_active seen below:

if (!$this->logic_m->cliqidcheck($cliqid)){
                $cliqid = 6;
            }

The above line is what is giving me problems. No matter what value, $cliqid is ALWAYS set to 6. Whether cliqidcheck returns true or false.

Here is cliqidcheck($cliqid)

    public function cliqidcheck($cliqid)
    {
        if ((ctype_digit($cliqid)) AND ($this->checkcliqidexist($cliqid)))
        {
            return true;
        } else {
            return false;
        }
    }

I have tested cliqidcheck with manually entered values and it always returns the correct value. In addition, i've flat out removed the cliqidcheck from the change_active model and it works perfectly.

I also echo'ed the variable $newcliqid in the controller and found the correct value.

I am hoping this is just a simple problem that I'm overlooking. Thanks for the help! Please let me know if more info is required.

Upvotes: 0

Views: 1677

Answers (1)

Your Common Sense
Your Common Sense

Reputation: 157919

Instead of verbal explanations, wouldn't be it better to post either the debugging code

var_dump($cliqid);
$tmp = $this->logic_m->cliqidcheck($cliqid);
if (!$tmp) {
    $cliqid = 6;
}
var_dump($tmp, $cliqid);
die;

and it's output.

Even without posting it here it will convince you that if statement actually never "running regardless of true false"

Setting full error reporting also helps (with finding typos and such)

ini_set('display_errors',1);
error_reporting(E_ALL);

Also a note on excessive code. This statement

if (condition)
{
    return true;
} else {
    return false;
}

can (and should, in my opinion) be shortened to 

return (condition);

Same goes for insert id. Why not to make it just 

return $this->db->insert_id();

without all that windy

if ($newcliqid) {
    return $newcliqid;
} else {
    return false;
}

which is actually a mere tautology

Upvotes: 2

Related Questions