CODEWITHSUNDEEP
rubyactiverecordruby-on-rails-3.1ruby-on-rails-3.2rubygems
Vinay
Vinay

Reputation: 237

Using Closure_tree gem instead of Awesome nested set

Hi I followed the link to set up closure_tag gem.

When i tried to use closure_tree syntax in the following way (newStructure.find_or_create_by_path(parent) instead of newStructure.move_to_child_of(parent)) ... got the following error :

"Can't mass-assign protected attributes: ancestor, descendant, generations"

is this the correct way of using newStructure.find_or_create_by_path(parent) ? 

def self.import(path)

    newStructure = FileOrFolder.find(:first, :conditions=>["fullpath = ?", path])
    if newStructure
      return newStructure
    end

    newStructure = FileOrFolder.new
    newStructure.fullpath = path
    pathbits = path.split('/')
    newStructure.name = pathbits.last
    newStructure.save




    parentpath = path.sub(/#{Regexp.escape(pathbits.last)}$/, '')
        if parentpath.length > 1
          parentpath.sub!(/\/$/,'')
          parent = FileOrFolder.find(:first, :conditions=>["fullpath = ?", parentpath])
          unless parent
            parent = FileOrFolder.import(parentpath)
          end
          #newStructure.move_to_child_of(parent);
          **newStructure.find_or_create_by_path(parent);**
        end
        newStructure.save
        return newStructure

      end






database table looks like : 

mysql> select * from testdb7.file_or_folders limit 10;
+------+-----------+------+------+----------+------------------------+---------------------+---------------------+
| id   | parent_id | lft  | rgt  | fullpath | name                   | created_at          | updated_at          |
+------+-----------+------+------+----------+------------------------+---------------------+---------------------+
| 6901 |      NULL | NULL | NULL | NULL     |                        | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6902 |      6901 | NULL | NULL | NULL     | devel                  | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6903 |      6902 | NULL | NULL | NULL     | Bcontrol               | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6904 |      6903 | NULL | NULL | NULL     | perfect                | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6905 |      6904 | NULL | NULL | NULL     | matlab                 | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6906 |      6905 | NULL | NULL | NULL     | test                   | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6907 |      6906 | NULL | NULL | NULL     | smoke                  | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6908 |      6907 | NULL | NULL | NULL     | Control_System_Toolbox | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6909 |      6908 | NULL | NULL | NULL     | tsmoke_are.m           | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
| 6910 |      6908 | NULL | NULL | NULL     | tsmoke_bode.m          | 2013-06-25 18:49:04 | 2013-06-25 18:49:04 |
+------+-----------+------+------+----------+------------------------+---------------------+---------------------+



FileOrFolder Load (14560.8ms)  SELECT `file_or_folders`.* FROM `file_or_folders` INNER JOIN `file_or_folder_hierarchies` ON `file_or_folders`.`id` = `file_or_folder_hierarchies`.`descendant_id` INNER JOIN (
 SELECT ancestor_id
 FROM `file_or_folder_hierarchies`
 GROUP BY 1
 HAVING MAX(`file_or_folder_hierarchies`.generations) = 0
 ) AS leaves ON (`file_or_folders`.id = leaves.ancestor_id) WHERE `file_or_folder_hierarchies`.`ancestor_id` = 147 ORDER BY `file_or_folder_hierarchies`.generations asc
  EXPLAIN (13343.7ms)  EXPLAIN SELECT `file_or_folders`.* FROM `file_or_folders` INNER JOIN `file_or_folder_hierarchies` ON `file_or_folders`.`id` = `file_or_folder_hierarchies`.`descendant_id` INNER JOIN (
 SELECT ancestor_id
 FROM `file_or_folder_hierarchies`
 GROUP BY 1
 HAVING MAX(`file_or_folder_hierarchies`.generations) = 0
 ) AS leaves ON (`file_or_folders`.id = leaves.ancestor_id) WHERE `file_or_folder_hierarchies`.`ancestor_id` = 147 ORDER BY `file_or_folder_hierarchies`.generations asc
EXPLAIN for: SELECT `file_or_folders`.* FROM `file_or_folders` INNER JOIN `file_or_folder_hierarchies` ON `file_or_folders`.`id` = `file_or_folder_hierarchies`.`descendant_id` INNER JOIN (
            SELECT ancestor_id
            FROM `file_or_folder_hierarchies`
            GROUP BY 1
            HAVING MAX(`file_or_folder_hierarchies`.generations) = 0
          ) AS leaves ON (`file_or_folders`.id = leaves.ancestor_id) WHERE `file_or_folder_hierarchies`.`ancestor_id` = 147 ORDER BY `file_or_folder_hierarchies`.generations asc
+----+-------------+----------------------------+--------+------------------------------------------------------------------------------------+----------------------------------+---------+--------------------+---------+---------------------------------+
| id | select_type | table                      | type   | possible_keys                                                                      | key                              | key_len | ref                | rows    | Extra                           |
+----+-------------+----------------------------+--------+------------------------------------------------------------------------------------+----------------------------------+---------+--------------------+---------+---------------------------------+
|  1 | PRIMARY     | file_or_folder_hierarchies | ref    | index_file_or_folders_on_ans_des,index_file_or_folder_hierarchies_on_descendant_id | index_file_or_folders_on_ans_des | 4       | const              |      15 | Using temporary; Using filesort |
|  1 | PRIMARY     | <derived2>                 | ALL    | NULL                                                                               | NULL                             | NULL    | NULL               |  104704 | Using where; Using join buffer  |
|  1 | PRIMARY     | file_or_folders            | eq_ref | PRIMARY                                                                            | PRIMARY                          | 4       | leaves.ancestor_id |       1 | Using where                     |
|  2 | DERIVED     | file_or_folder_hierarchies | index  | NULL                                                                               | index_file_or_folders_on_ans_des | 8       | NULL               | 1340096 |                                 |
+----+-------------+----------------------------+--------+------------------------------------------------------------------------------------+----------------------------------+---------+--------------------+---------+---------------------------------+

Upvotes: 1

Views: 1083

Answers (1)

mrm
mrm

Reputation: 5232

I'm the author of closure_tree. 4.2.3 is on it's way with the fix for attr_accessible. I'm just waiting for Travis to finish testing it.

It looks like your whole import method could be replaced with this line:

# Assumes that path is a string that looks like this: "/usr/local/bin/ruby"
def import(path)
  FileOrFolder.find_or_create_by_path(path.split("/"))
end

This assumes you have this FileOrFolder setup:

class FileOrFolder < ActiveRecord::Base
  acts_as_tree
  before_create :set_fullpath
  def set_fullpath
    if root?
      self.fullpath = "/#{name}"
    else
      self.fullpath = "/#{parent.ancestry_path.join("/")}/#{name}"
    end
  end
end

Please take a look at the spec directory. You'll find tons of other examples.

Upvotes: 1

Related Questions