CODEWITHSUNDEEP
c#mysql.netsqldatabase
Robert Vlasiu
Robert Vlasiu

Reputation: 402

Updating Database Command in C#

        using (MySqlCommand bb = new MySqlCommand("UPDATE  members SET  Begin = 1 WHERE id ='" + uid + "';"))
        {
            bb.Connection = con;
            con.Open();
            using (MySqlCommand fff = new MySqlCommand("UPDATE  members SET  b = 1 WHERE id ='" + uid + "';"))
            {
                fff.Connection = con;
            }
            this.Hide();
            Main main = new Main();
            main.Show();
        }

I'm trying to update both tables, B and Begin to 1 to the current logged in user (my uid command:

  using (MySqlCommand id = new MySqlCommand("SELECT id FROM members WHERE username='" + textBox1.Text + "';"))
                            {
                                id.Connection = con;
                                MySqlDataReader read3 = cmd.ExecuteReader();
                                read3.Dispose();
                                int idd = (int)id.ExecuteScalar();
                                uid = idd;
                                Begin.uid = idd;
                                MySqlDataReader read4 = id.ExecuteReader();
                                read4.Dispose();
                                id.Dispose();
                            }

I don't know why but it doesn't update the database.

Upvotes: 1

Views: 166

Answers (2)

gzaxx
gzaxx

Reputation: 17590

First of all user parametrized querys, second you do call ExecuteNonQuery() on any of your SqlCommands.

using (MySqlCommand bb = new MySqlCommand("UPDATE  members SET  Begin = 1 WHERE id = @id;"))
{
    bb.Parameters.AddWithValue("@id", uid);
    bb.Connection = con;
    con.Open();

    bb.ExecuteNonQuery();

    using (MySqlCommand fff = new MySqlCommand("UPDATE  members SET  b = 1 WHERE id = @id;"))
    {
        fff.Parameters.AddWithValue("@id", uid);
        fff.Connection = con;

        fff.ExecuteNonQuery();
    }

    this.Hide();
    Main main = new Main();
    main.Show();
}

Upvotes: 0

Darren
Darren

Reputation: 70728

You're not executing the command.

You need fff.ExecuteScalar(); And bb.ExecuteScalar();

Or ExecuteNonQuery();

Also you are vulnerable to SQL Injection, try using paramerterized queries.

For instance:

 bb.CommandText = "UPDATE members SET  Begin = 1 WHERE id = @id";  
 bb.Parameters.AddWithValue("@id", id);
 bb.ExecuteNonQuery();

Upvotes: 5

Related Questions