CODEWITHSUNDEEP
c#excel-interop
griegs
griegs

Reputation: 22770

Closing an Excel Workbook

I have a bit of code that opens an xls workbook;

Excel.Workbooks workBooks;
workBooks = excelApp.Workbooks;
workbook = workBooks.Open(sourceFilePath + sourceFileName + ".xls");

I then get the work sheet;

worksheets = workbook.Worksheets;
worksheet = worksheets.get_Item("Standard");

I then save the file as a csv;

worksheet.SaveAs(sourceFilePath + sourceFileName + ".csv", Excel.XlFileFormat.xlCSVWindows, Type.Missing, Type.Missing, false, false, Excel.XlSaveAsAccessMode.xlNoChange, Type.Missing, Type.Missing, Type.Missing);

Then I try to close the workbook;

Marshal.FinalReleaseComObject(worksheet);
Marshal.FinalReleaseComObject(worksheets);
workbook.Close();
Marshal.FinalReleaseComObject(workbook);

However, every time i get to the line workbook.Close(), the system stops.

If I do not do the SaveAs then the workbook closes just fine.

How do I close a workbook?

edit

Looking at Task Manager shows me that Excel.exe is still running. Closing it will produce an error in my code.

edit 2

I have already seen the referenced SO post and it did not solve the issue.

Upvotes: 7

Views: 26921

Answers (5)

VSimanin
VSimanin

Reputation: 5

This work for me. EXCEL.EXE will be kill after close you program.

Excel.Application objExcel;
Excel._Workbook objBook;
Excel.Workbooks objBooks;
Excel._Worksheet objSheet;
Excel.Sheets objSheets;

objExcel = new Excel.Application();
objBooks = objExcel.Workbooks;
objBook = objExcel.Workbooks.Open(Application.StartupPath+@"/"+"template.xls");
objSheets = objBook.Worksheets;
objSheet = (Excel._Worksheet)objBook.ActiveSheet;

//....you code modify excel book

objBook.Close(true, objBook, Missing.Value);
objExcel.Quit();
Marshal.ReleaseComObject(objSheet);
Marshal.ReleaseComObject(objSheets);
Marshal.ReleaseComObject(objBook);
Marshal.ReleaseComObject(objBooks);
Marshal.ReleaseComObject(objExcel);

Upvotes: 0

Eli Algranti
Eli Algranti

Reputation: 9007

This question keeps popping up see:

How to properly clean up Excel interop objects in C#

You need to call System.Runtime.InteropServices.Marshal.ReleaseComObject() on every excel object you use, even invisible ones, e.g.:

var worksheet = excelApp.Worksheets.Open()

There are two objects here: 1. The obvious 'Worksheet' opened with Open() 2. The "invisible" collection 'Worksheets'.

Both of them need to be released (so you better keep a reference for Worksheets):

var wkCol = excelApp.Worksheets;
var worksheet = wkCol.Open();

Upvotes: -1

SeeMoreGain
SeeMoreGain

Reputation: 1273

Why not combine the 2. This will take care of any problems with closing before saving is complete. There is an option in the Close method to save the file.

workbook.Close(true, fileName, Missing.Value);

Also if the file is saving correctly, and your problem is purely because the excel.exe process is still running, it could be because you didn't close and release EVERYTHING needed. I have had this before and developed a more complete close down routine. My code for shutting down an excel file is:

        book.Close(true, fileName, Missing.Value); //close and save individual book
        allBooks.Close(); //close all books
        excel.Quit();
        Marshal.ReleaseComObject(allCells); //any used range objects
        Marshal.ReleaseComObject(sheet);
        Marshal.ReleaseComObject(sheets);
        Marshal.ReleaseComObject(book);
        Marshal.ReleaseComObject(allBooks);
        Marshal.ReleaseComObject(excel);

This works 100% of the time for me.

Upvotes: 6

Hercules
Hercules

Reputation: 138

Here is the solution

first: using EXCEL = Microsoft.Office.Interop.Excel;

and then, path is where your excel locates.

        EXCEL.Application excel = new EXCEL.Application();
        try
        {
            EXCEL.Workbook book = excel.Application.Workbooks.Open(path);
            EXCEL.Worksheet sheet = book.Worksheets[1];
            // yout operation

        }
        catch (Exception ex) { MessageBox.Show("readExcel:" + ex.Message); }
        finally
        {
            KillExcel(excel);
            System.Threading.Thread.Sleep(100);
        }



    [DllImport("User32.dll")]
    public static extern int GetWindowThreadProcessId(IntPtr hWnd, out int ProcessId);
    private static void KillExcel(EXCEL.Application theApp)
    {
        int id = 0;
        IntPtr intptr = new IntPtr(theApp.Hwnd);
        System.Diagnostics.Process p = null;
        try
        {
            GetWindowThreadProcessId(intptr, out id);
            p = System.Diagnostics.Process.GetProcessById(id);
            if (p != null)
            {
                p.Kill();
                p.Dispose();
            }
        }
        catch (Exception ex)
        {
            System.Windows.Forms.MessageBox.Show("KillExcel:" + ex.Message);
        }
    }

Upvotes: 10

Tenescu Andrei
Tenescu Andrei

Reputation: 337

Have you considered the fact that the system might still be in the process of saving the file when you attempt to close it? I'm just saying, to be sure add a delay(Thread.Sleep(1000) in C# for example) before the close to see if this is the problem.

Upvotes: 0

Related Questions