CODEWITHSUNDEEP
phpxml-parsing
Satch3000
Satch3000

Reputation: 49384

Speed up simple_xml_file or thread

I need to speed up simple_xml_file part of the following code.

I was thinking multi threading ... Any ideas?

How could I speed up that part of the code where it get's the xml file.

<?php


$k = $_GET['key'];


echo "<ul id=\"List\">\n";
foreach ($feed as $url2):
$title=$url2['name'];
$url=$url2['url'];

if (strpos($url, $key)==true) {
//Load XML
$temp = simplexml_load_file("http://api.site.com/web?uri=$url"); //Need to speed this
//Echo
echo "<li>".$temp->filter->filterResponse->filteredText."</li>";
}else{
//URL Contains Nothing Check Title
if(strpos($title,$key)==true)
{

$temp = simplexml_load_file("http://api.site.com/web?uri=$url"); //Need to speed this
//Echo
echo "<li>".$temp->filter->filterResponse->filteredText."</li>";
}
}

endforeach;
echo "</ul>";

?>

Upvotes: 0

Views: 139

Answers (2)

complex857
complex857

Reputation: 20753

You could make the http requests for the API server run in parallel with curl, something like this:

//create the multiple cURL handle
$mh = curl_multi_init();
// gather curl handlers into an array for later use and add them to the multi request
$requests = array();
foreach ($feed as $url2) {
    $url=$url2['url'];
    $title=$url2['name'];

    // strpos can return 0 which will evaluate to false even if the needle is in fact in the beginning of the haystack
    if (strpos($url, $key) !== false || strpos($title,$key) !== false) {
        $ch = curl_init("http://api.site.com/web?uri=".$url);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($ch, CURLOPT_HEADER, false);
        curl_multi_add_handle($mh, $ch);
        $requests[] = $ch;
    }
}

// execute the requests
$running=null;
do {
    // exec the multy request, update the $running variable
    while (CURLM_CALL_MULTI_PERFORM === curl_multi_exec($mh, $running));
    // break the loop if we are done
    if (!$running) { 
        break;
    }
    // block until something interesting happens on a request
    while (($res = curl_multi_select($mh)) === 0);
    // if its an error, do something about it!
    if ($res === false) {
        // handle select errors here!
        break;
    }
    // repeat forever (or until we break out)
} while (true);

// loop trough the results
foreach ($requests as $ch) {
    // load resposne
    $xml = simplexml_load_string(curl_multi_getcontent($ch));

    // do your original processing
    echo "<li>".$xml->filter->filterResponse->filteredText."</li>";

    // clean up curl handler
    curl_multi_remove_handle($mh, $ch);
}
curl_multi_close($mh);

I can't really test this without real data (apart from the syntax) but you get the idea. Your usage of strpos() looks strange to me, it might reutnr 0 (number zero) if the needle is in the beginning of the haystack but 0 == true evaulates to false, i'm not sure if this is you wanted.

Upvotes: 1

matino
matino

Reputation: 17715

PHP doesn't support multithreading, so there is not much you can do.
BTW. I think its much cleaner to join both conditions, since you perform the same actions anyway:

if (strpos($url, $key) == true OR strpos($title,$key) == true) {
   //Load XML
   $temp = simplexml_load_file("http://api.site.com/web?uri=$url"); //Need to speed this
   //Echo
   echo "<li>".$temp->filter->filterResponse->filteredText."</li>";
}

Upvotes: 1

Related Questions