CODEWITHSUNDEEP
javascriptfunctionvariablesscope
Raindy Saha
Raindy Saha

Reputation: 3

Javascript can't read variable in function()

I have an example on this code:

<script>
    for(var i=1; i<3; i++){
        setTimeout(function(){
            say("HELLO NUMBER " + i);
        }, i * 2000);
    }

    function say(text){
        alert(text);
    }
</script>

And output I need is :

alert("HELLO NUMBER 1");

alert("HELLO NUMBER 2");

But in this case, I still get output :

alert("HELLO NUMBER 3");

Anyone can help for this? thanks :)

Upvotes: 0

Views: 538

Answers (4)

Kousik
Kousik

Reputation: 22425

<script>
    function doSetTimeout(i) {
         setTimeout(function() { say("HELLO NUMBER " + i); }, 3000);
    }

    for(var i=1; i<3; i++){
        doSetTimeout(i);
    }

    function say(text){
    alert(text);
   }
</script>

Upvotes: 0

Francisco Meza
Francisco Meza

Reputation: 883

you need a closure for the value of i for each iteration:

for (var i=1; i<3; i++) {
    (function(j){
        setTimeout(function() { alert("HELLO NUMBER " + j); }, j*2000);
    })(i)
}

Upvotes: 0

h3nr7
h3nr7

Reputation: 86

Another way.

var out = [];
for(var i=0; i<3; ++i){
    out.push(i+1);
    setTimeout(function(){
        say("HELLO NUMBER " + out.shift());
    }, i * 2000);
}

function say(text){
    alert(text);
}

Upvotes: 0

Arun P Johny
Arun P Johny

Reputation: 388316

Classic problem with closure

for(var i=1; i<=3; i++){
    (function(num){
        setTimeout(function(){
            say("HELLO NUMBER " + num);
        }, num * 2000);

    })(i)
}

function say(text){
    alert(text);
}

Demo: Fiddle

You are using a closure variable i inside the setTimeout callback, whose value is evaluated only when the callback is executed by then the value of i will be updated by the outside loop

Upvotes: 7

Related Questions