CODEWITHSUNDEEP
c#winformsforeachcontrolsenumeration
Altimus Prime
Altimus Prime

Reputation: 2327

foreach control c# skipping controls

I have the following loop to remove the buttons in my C# Windows Forms application. The only problem is that it skips every other button. How do I go about removing all the button controls from my form?

foreach (Control cntrl in Controls)
{
    if(cntrl.GetType() == typeof(Button))
    {
        Controls.Remove(cntrl);
        cntrl.Dispose();
    }
}

Upvotes: 5

Views: 2496

Answers (3)

zimdanen
zimdanen

Reputation: 5626

Surprised that's not erroring on you, since you're modifying the collection as you're iterating over it. Use a for loop and start at the end:

for (int ii = Controls.Count - 1; ii >= 0; ii--)
{
    Control cntrl = Controls[ii];
    Controls.remove(cntrl);
    cntrl.Dispose();
}

(Starting at the end because otherwise you'd be changing the indexes of each control as you iterated.)

Upvotes: 2

Armen Aghajanyan
Armen Aghajanyan

Reputation: 368

Youre iterating over the same collection from whitch youre removing. Use this code:

    List<Control> cleanControls = new List<Control>();
    foreach(Control ctr in Controls)
    {
       if(cntrl.GetType() != typeof(Button))
       {
          cleanControls.Add(ctr);
       }
       else
       {
         ctr.Dispose();
       }
    } 
    Controls = cleanControls;

That's It! Hope I helped!

Upvotes: 0

McGarnagle
McGarnagle

Reputation: 102743

I think this way is a bit more readable:

var controlsToRemove = Controls.OfType<Button>().ToArray();
foreach (var control in controlsToRemove)
{
    Controls.Remove(control);
    cntrl.Dispose();
}

Calling ToArray() makes a new concrete collection, so that you can enumerate over one and modify the other.

Upvotes: 11

Related Questions