CODEWITHSUNDEEP
vbaexcel
user2385809
user2385809

Reputation: 1005

How to Copy a cell's range into the value of another cell

I am writing a code that goes through a given range of cells with a for each loop. if theses calls do not satisfy an if statement withing the "for each", i need to write the range of that cell on another sheet. Ex: cells A20 and A36 do not conform so I want to write A20 and36 on another sheet. this way i will have a list of all the cells that require attention.Here is my code below:

    r = 5
    Set sht1 = Sheets("DataSheet")
    Set sht2 = Sheets("DiscrepancyReport")
On Error GoTo DiscrepancySheetError
    sht2.Select
On Error GoTo DataSheetError
    sht1.Select
On Error GoTo 0

        lastr = ActiveSheet.range("A1").Offset(ActiveSheet.Rows.Count - 1, 0).End(xlUp).Row
        lastr = lastr - 1

'Column 1: WP
        Set colrg = range("A3:A" & lastr)
            For Each cell In colrg
                If (cell.Value) = 6.01 Or (cell.Value) = 6.03 Or (cell.Value) = 3.04 Or (cell.Value) = 6.27 Then
                Else
                    '## The following line makes no sense but i wrote it so you understand what i want to do
                    currentcell.range.Copy Destination:=sht2.range("A" & r)
                    ActiveCell.Offset(0, 1).Select
                        ActiveCell.Value = "Not a valid WP"
                    r = r + 1
                End If
            Next

Thanks ahead!

Upvotes: 0

Views: 388

Answers (3)

Bharath Raja
Bharath Raja

Reputation: 181

Here is an updated code of Andy's and Santosh's code - 

Sub test()

Dim sht1 As Worksheet
Dim sht2 As Worksheet
Dim r As Long, lastr As Long

r = 3
Set sht1 = Sheets("DataSheet")
Set sht2 = Sheets("DiscrepancyReport")

With sht1
    lastr = .Range("A" & .Rows.Count).End(xlUp).Row
    If lastr < 3 Then lastr = 3

    Set colrg = Range("A3:A" & lastr)
End With


For Each cell In colrg
    If (cell.Value) <> 6.01 Or (cell.Value) <> 6.03 Or (cell.Value) <> 3.04 Or (cell.Value) <> 6.27 Then
       '## The following line makes no sense but i wrote it so you understand what i want to do
        sht2.Range("A" & r).value=Replace(cell.Address, "$", "")

        'Comment the appropriate one below

        'If you want this to be written in the 2nd sheet, below is the code, else comment it.
        sht2.Range("B" & r) = "Not a valid WP"

        'If you want this to be written in the 1st sheet, below is the code, else comment it.
        cell.offset(0,1).value = "Not a valid WP"
        r = r + 1
    End If
Next

End Sub

Hope this helps.

Upvotes: 0

Andy G
Andy G

Reputation: 19367

I'm assuming you wanted to put "Not a valid WP" into the DataSheet, and there is no need to use Copy:

Sub CollectRanges()
    r = 5
    Set sht1 = Sheets("DataSheet")
    Set sht2 = Sheets("DiscrepancyReport")
'On Error GoTo DiscrepancySheetError
    sht2.Select
'On Error GoTo DataSheetError
    sht1.Select
On Error GoTo 0

        lastr = ActiveSheet.Range("A1").Offset(ActiveSheet.Rows.Count - 1, 0).End(xlUp).Row
        lastr = lastr - 1

'Column 1: WP
        Set colrg = Range("A3:A" & lastr)
            For Each cell In colrg
                If (cell.Value) = 6.01 Or (cell.Value) = 6.03 Or (cell.Value) = 3.04 Or (cell.Value) = 6.27 Then
                Else
                    sht2.Cells(r, 1).Value = cell.Address
                    cell.Offset(0, 1).Value = "Not a valid WP"
                    r = r + 1
                End If
            Next
End Sub

Upvotes: 1

Santosh
Santosh

Reputation: 12353

Here is the updated code assuming your data starts from 3rd row.
Avoid using Select / Activate in the code. Refer this link

Sub test()

    Dim sht1 As Worksheet
    Dim sht2 As Worksheet
    Dim r As Long, lastr As Long

    r = 3
    Set sht1 = Sheets("DataSheet")
    Set sht2 = Sheets("DiscrepancyReport")

    With sht1
        lastr = .Range("A" & .Rows.Count).End(xlUp).Row
        If lastr < 3 Then lastr = 3

        Set colrg = Range("A3:A" & lastr)
    End With


    For Each cell In colrg
        If (cell.Value) = 6.01 Or (cell.Value) = 6.03 Or (cell.Value) = 3.04 Or (cell.Value) = 6.27 Then
        Else
            '## The following line makes no sense but i wrote it so you understand what i want to do
            cell.Copy Destination:=sht2.Range("A" & r)
            sht2.Range("B" & r) = "Not a valid WP"
            r = r + 1
        End If
    Next


End Sub

Upvotes: 0

Related Questions