Reputation: 393
I have created a javascript object as part of a visualization I am working on, and am funning into an issue with the object's instance variables. The relevant code is below:
function bubble() {
//don't use these functions elsewhere--only modify them to change behavior
this.color;
this.bubbleCircles = chart.selectAll("circle");
//.data(array,function(d){return d['date'];});
this.bubbleCirclesEnter = function(selection){
selection.enter().append("circle")
.style('stroke',this.color)
.style('fill',this.color)
.attr("cx", function (d, i) { return x(i); })
.attr("cy", function (d) { return y(d["measure"]) - 1.5*bubbleRadius; })
.attr("r", 0);
console.log(this.color);
};
this.bubbleCirclesEnterTransition = function(selection){
return selection.transition()
.duration(400)
.delay(function(d,i){return i*segmentDuration;})
.ease('elastic')
.attr("r", bubbleRadius);
};
this.bubbleText = chart.selectAll('.label');
//.data(array,function(d){return d['date'];});
this.bubbleTextEnter = function(selection){
selection
.enter().append("text")
.attr("x", function (d, i) { return x(i) - (13.0/16)*bubbleNumberSize; })
.attr("y", function (d, i) { return y(d['measure']) - 1.5*bubbleRadius + bubbleNumberSize*(5.0/16); })
.style("font-size", bubbleNumberSize.toString() + "px")
.style('fill',white)
.style('fill-opacity',1.0)
.style('stroke',white)
.style('stroke-opacity',1.0)
.text(function (d, i) { return d['measure'].toFixed(2); });
};
//actually use these ones
this.enter = function() {
this.bubbleCircles = this.bubbleCircles.call(this.bubbleCirclesEnter);
this.bubbleText = this.bubbleText.call(this.bubbleTextEnter);
};
this.enterTransition = function() {
this.bubbleCircles.call(this.bubbleCirclesEnterTransition);
};
this.draw = function() {
this.enter();
this.enterTransition();
};
this.setData = function(dataSet) {
this.bubbleCircles = this.bubbleCircles.data(dataSet,function(d){ return d['date']; });
this.bubbleText = this.bubbleText.data(dataSet,function(d){ return d['date']; });
};
this.setColor = function(bubblesColor) {
this.color = bubblesColor;
};
};
The problem is with the this.color variable. It gets set when the 'setColor' method is called, but, later, when bubbleCirclesEnter is called (via this.draw and this.enter), a console.log of the variable shows that it is undefined.
If anyone could point out what I am doing wrong, I would really appreciate it!
Upvotes: 2
Views: 4102
Reputation: 391
this
changes scope throughout the object. When you enter any of your functions, the scope of this
moves from a global scope to the local scope of the function. Generally what I've seen done is to set a new variable equal to this as another member. This article explains in better words than I can: http://ryanmorr.com/understanding-scope-and-context-in-javascript/
function bubble() {
//don't use these functions elsewhere--only modify them to change behavior
this.color;
this.bubbleCircles = chart.selectAll("circle");
var me = this;
. . .
this.bubbleCirclesEnter = function(selection){
selection.enter().append("circle")
.style('stroke',me.color)
.style('fill',me.color)
.attr("cx", function (d, i) { return x(i); })
.attr("cy", function (d) { return y(d["measure"]) - 1.5*bubbleRadius; })
.attr("r", 0);
console.log(me.color);
};
Upvotes: 3
Reputation: 18387
Just a idea:
Try to declare the color variable in your function:
function bubble() {
//don't use these functions elsewhere--only modify them to change behavior
var color = "";
//rest of the code
Upvotes: -1