CODEWITHSUNDEEP
javascriptvalidation
Zephram
Zephram

Reputation: 499

Javascript IF blocks get skipped

I'm using this code to validate a form:

        if (isEmpty(email)) {
            alert("1");
            return false;
        }
        else if (!isEmail(email)) {
            alert("2");
            return false;
        }

        if (isEmpty(name)) {
            alert("3");
            return false;
        }

        if (isEmpty(age)) {
            alert("4");
            return false;
        }
        else if (!isAge(age)) {
            alert("5");
            return false;
        }

        if (isEmpty(city)) {
            alert("6");
            return false;

        }

        if (isEmpty(comments)) {
            alert("7");
            return false;
        }

When hitting the "Submit" button, if the first two conditions do work(The ones that check if the email var is empty or not in email address format) - meaning that if I leave the email input empty or not in an email address format I get the alert (1 or 2).

The problem is that the rest of the validations get skipped and it doesn't matter if I leave another input empty or not in format.

Also, if I take the first IF block:

 if (isEmpty(email)) {
            alert("1");
            return false;
        }
        else if (!isEmail(email)) {
            alert("2");
            return false;
        }

And move it to the end of the validation block, everything works just fine.

I'm guessing I have a wrong syntax somewhere but I spent 2 hours looking and just couldn't find it.

P.S.

here are the two validation functions I'm using:

function isEmpty(field) {
        if ((field == null || field == "")) {
            return true;
        }
        return false;
    }


function isEmail(field) {
        var atpos = field.indexOf("@");
        var dotpos = field.lastIndexOf(".");
        if (atpos < 1 || dotpos < atpos + 2 || dotpos + 2 >= x.length) {
            return false;
        }
    }

Upvotes: 1

Views: 195

Answers (4)

The Code
The Code

Reputation: 1309

the return statement exits the function to get all the validations run

  1. keep all the validations in if else if blocks and keep on using return false every time. or
  2. set a variable to false whenever condition fails and then return the value. as j00lz said.

Upvotes: 2

Roland Jansen
Roland Jansen

Reputation: 2783

You use x.length in the isEmail function, but x is not defined.

Upvotes: 2

Matt Grubb
Matt Grubb

Reputation: 136

What happens if you change it to this:

    if (isEmpty(email)) {
        alert("1");
        return false;
    }
    else if (!isEmail(email)) {
        alert("2");
        return false;
    }
    else if (isEmpty(name)) {
        alert("3");
        return false;
    }
    else if (isEmpty(age)) {
        alert("4");
        return false;
    }
    else if (!isAge(age)) {
        alert("5");
        return false;
    }
    else if (isEmpty(city)) {
        alert("6");
        return false;
    }
    else if (isEmpty(comments)) {
        alert("7");
        return false;
    }

I'm just curious as to what happens if you make the whole thing one big if statement rather than breaking it up into parts, considering it's not going to change the validation process.

P.S.

I'm not sure if you realize or not, but with the way you have it set up, once one of the first if statements comes back false, returning false with in that if statement will end the whole method you're working in, meaning it won't run any other parts of it. So if you're shooting for displaying an alert for each and every empty input, etc, it won't happen this way.

Upvotes: 1

j00lz
j00lz

Reputation: 281

The 

return false;

ends the function and stops the rest of the code being executed.

Instead set a variable:

result="false";

and at the end of the function add 

return result;

Upvotes: 1

Related Questions