CODEWITHSUNDEEP
phprandom
user2426701
user2426701

Reputation:

PHP generate random usernames

I am doing a little function to generate random usernames, as the following:

public static function nicknames($data) {
    if ($data['request'] == 'nickAvailable') {

        foreach ($data as $value)
            if (is_array($value))
                $nick = $value['nickname'];

        $random = rand(2, 2);
        $nickname = $nick . '_' . $random;

        $count = 3;
        $nicknames = array();
        for ($i = 1; $i <= $count; $i++) {
            $select = self::$db->select('users', 'nickname', array('nickname' => $nickname));

            if (count($select) == 0) {
                $nicknames[] = $nickname;
            } else {
                $count = $count + 1;
            }
        }

        $array = array("status" => 0,
            "errors" => $nicknames,
            "data" => array());

        model::json($array);
    }

}

The only problem I have is that $random is just executed one time and not on each loop. I need 3 different usernames to be in the array, and they must be different from each other. How can I edit my code to achieve this? Thanks for any suggestion

Upvotes: 4

Views: 2538

Answers (2)

Amal Murali
Amal Murali

Reputation: 76656

As of now, you're not generating a random number.

$random = rand(2, 2);

This will always be 2.

Here's how I'd do it:

for ($i = 1; $i <= $count; $i++) 
    {

    $random = rand(1, 3);
    $nickname = $nick . '_' . $random;
        $select = self::$db->select('users', 'nickname', array('nickname' => $nickname));

        if (count($select) == 0) {
            $nicknames[] = $nickname;
        } else {
            $count = $count + 1;
        }
    }

Hope this helps!

Upvotes: 1

Lee
Lee

Reputation: 10603

Place the random number generator and nickname building variable at the start of your loop. Also increase the range of numbers that rand is allowed to return, as it will always return 2 at the moment

$usernames = array();
do {

 // inside generate random number, 
 // build nickname, 
 // query to see if its taken, 
 // and if NOT taken, add to the usernames array

} while(count($usernames) < 3);

Upvotes: 1

Related Questions