CODEWITHSUNDEEP
c++dynamic-memory-allocation
Rasoul
Rasoul

Reputation: 3847

Incrementally dynamic allocation of memory in C/C++

I have a for-loop that needs to incrementally add columns to a matrix. The size of the rows is known before entering the for-loop, but the size of the columns varies depending on some condition. Following code illustrates the situation:

  N = getFeatureVectorSize();
  float **fmat; // N rows, dynamic number of cols     
  for(size_t i = 0; i < getNoObjects(); i++)
  {
    if(Object[i] == TARGET_OBJECT)
    {
      float *fv = new float[N];
      getObjectFeatureVector(fv);    
      // How to add fv to fmat?
    }
  }

Edit 1 This is how I temporary solved my problem:

  N = getFeatureVectorSize();
  float *fv = new float[N];
  float *fmat = NULL;
  int col_counter = 0;
  for(size_t i = 0; i < getNoObjects(); i++)
  {
    if(Object[i] == TARGET_OBJECT)
    {
      getObjectFeatureVector(fv);    
      fmat = (float *) realloc(fmat, (col_counter+1)*N*sizeof(float));
      for(int r=0; r<N; r++) fmat[col_counter*N+r] = fv[r];
      col_counter++;
    }
  }
  delete [] fv;
  free(fmat);

However, I'm still looking for a way to incrementally allocate memory of a two-dimensional array in C/C++.

Upvotes: 1

Views: 599

Answers (4)

Fozi
Fozi

Reputation: 5145

To elaborate the std::vector approach, this is how it would look like:

// initialize
N = getFeatureVectorSize();
vector<vector<float>> fmat(N);

Now the loop looks the same, you access the rows by saying fmat[i], however there is no pointer to a float. You simply call fmat[i].resize(row_len) to set the size and then assign to it using fmat[i][z] = 1.23.

In your solution I suggest you make getObjectFeatureVector return a vector<float>, so you can just say fmat[i] = getObjectFeatureVector();. Thanks to the C++11 move constructors this will be just as fast as assigning the pointers. Also this solution will solve the problem of getObjectFeatureVector not knowing the size of the array.

Edit: As I understand you don't know the number of columns. No problem: 

deque<vector<float>> fmat();

Given this function:

std::vector<float> getObjectFeatureVector();

This is how you add another column:

fmat.push_back(getObjectFeatureVector());

The number of columns is fmat.size() and the number of rows in a column is fmat[i].size().

Upvotes: 0

Fozi
Fozi

Reputation: 5145

To answer your original question

// How to add fv to fmat?

When you use float **fmat you are declaring a pointer to [an array of] pointers. Therefore you have to allocate (and free!) that array before you can use it. Think of it as the row pointer holder:

float **fmat = new float*[N];

Then in your loop you simply do 

fmat[i] = fv;

However I suggest you look at the std::vector approach since it won't be significantly slower and will spare you from all those new and delete.

Upvotes: 1

pattivacek
pattivacek

Reputation: 5833

If you want to do this without fancy data structures, you should declare fmat as an array of size N of pointers. For each column, you'll probably have to just guess at a reasonable size to start with. Dynamically allocate an array of that size of floats, and set the appropriate element of fmat to point at that array. If you run out of space (as in, there are more floats to be added to that column), try allocating a new array of twice the previous size. Change the appropriate element of fmat to point to the new array and deallocate the old one.

This technique is a bit ugly and can cause many allocations/deallocations if your predictions aren't good, but I've used it before. If you need dynamic array expansion without using someone else's data structures, this is about as good as you can get.

Upvotes: 0

Graham Griffiths
Graham Griffiths

Reputation: 2216

better - use boost::MultiArray as in the top answer here :

How do I best handle dynamic multi-dimensional arrays in C/C++?

trying to dynamically allocate your own matrix type is pain you do not need.

Alternatively - as a low-tech, quick and dirty solution, use a vector of vectors, like this :

C++ vector of vectors

Upvotes: 0

Related Questions