CODEWITHSUNDEEP
phpmysqlmysqli
MultiDev
MultiDev

Reputation: 10649

mysqli query only returning first row

I am migrating from mysql to mysqli, and I am having trouble returning more than one row from the database in a query.

$db = new mysqli($hostname, $sql_us, $sql_us_pwd, $sql_db); // This is already connected

function db_query($db, $query, $type = 'object') {

    global $db;

    $result = $db->query($query);

    if ($type == 'assoc') {
        while($row = $result->fetch_assoc()) {
          return $row;
        }
    } else {    
        while($row = $result->fetch_object()) {
          return $row;
        }   
    }

    mysqli_free_result($result);

}



$query = "SELECT * FROM `users`";
$user = db_query($db, $query);
print_r($user); // This is only returning the first row of results

I'm obviously trying to make a function where I can query the database and either return the results in an associative array or as an object. What am I doing wrong?

Upvotes: 1

Views: 3412

Answers (5)

Prathik Rajendran M
Prathik Rajendran M

Reputation: 1162

When you return in a function it stops executing at that point and goes back to the where it was called from with the value that you are returning.

In your case when you do a return $row, you are getting out of the function as soon as the first row is read.

Fix is:

$result = array();
if ($type == 'assoc') {
    while($row = $result->fetch_assoc()) {
      $result[] = $row;
    }

} else {    

    while($row = $result->fetch_object()) {
      $result[] = $row;
    }   
}
return $row;

Upvotes: 2

Padmanathan J
Padmanathan J

Reputation: 4620

You need to store while loop values into array try this

$rows = array();
if ($type == 'assoc') {
    while($row = $result->fetch_assoc()) {
      $rows[] = $row;
    }
} else {    
    while($row = $result->fetch_object()) {
      $rows[] = $row;
    }   
}
return $rows;

Upvotes: 2

George Kagan
George Kagan

Reputation: 6124

$arr = array();
if ($type == 'assoc') {
  while($row = $result->fetch_assoc()) {
    $arr[] = $row;
  }
}
else {    
  while($row = $result->fetch_object()) {
    $arr[] = $row;   
  }
}
return $arr;

Upvotes: 1

Code Lღver
Code Lღver

Reputation: 15603

Use this code:

$rows = array();
if ($type == 'assoc') {
    while($row = $result->fetch_assoc()) {
      $rows[] = $row;
    }
} else {    
    while($row = $result->fetch_object()) {
      $rows[] = $row;
    }   
}
return $rows;

You are using the return inside the while and return terminates the while loop after first iteration that's why you are getting only one row.

Upvotes: 2

Daniel A. White
Daniel A. White

Reputation: 190907

You are only returning the first row. You have to return an array.

Upvotes: 1

Related Questions