CODEWITHSUNDEEP
makefile
OLL
OLL

Reputation: 665

How do I handle files with spaces in my Makefile?

So some anonymous developers have decided to use a ridiculous convention of using spaces in their folder names that contain their source files. I would change these folders not to use spaces but sadly I don't make the rules around here so that's not an option (though I wish it were).

LUAC            = luac

SRC_DIR         = .
SOURCE          =                                                      \
stupid/naming\ convention/a.lua                                        \
stupid/naming\ convention/very\ annoying/b.lua                         \

vpath .lua $(SRC_DIR)

OUT_DIR         = ../out/
OUTPUT          = $(patsubst %.lua, $(OUT_DIR)/%.luac, $(SOURCE))


all: $(OUTPUT)

$(OUT_DIR)/%.luac: %.lua
    $(LUAC) "$<"
    mv luac.out "$@"

.PHONY: all

Simple Makefile. All it's meant to do is compile all the Lua files that I have and put them into an output directory.

No matter I do it keeps wanting to split the SOURCE string on the spaces in the folder, so I end with a beautiful error like this:

make: *** No rule to make target `stupid/naming ', needed by `all'.  Stop.

Is there a way to fix this without renaming the folders?

Thanks in advance.

Upvotes: 11

Views: 9489

Answers (4)

Ed.
Ed.

Reputation: 2062

Another strategy which works when you are generating your Makefile automatically is this one, also used in Perl's ExtUtils::MakeMaker: to separate the name formatted to be usable in recipes, versus it being usable as a dependency. The example here has a THISFILE and a THISFILEDEP.

AWKWARD_DIR = sub dir
AWKWARD_DIRDEP = sub\ dir
THISFILE = $(AWKWARD_DIR)/d1
THISFILEDEP = $(AWKWARD_DIRDEP)/d1
AWKWARD_DIR_EXISTS = $(AWKWARD_DIR)/.exists
AWKWARD_DIR_EXISTSDEP = $(AWKWARD_DIRDEP)/.exists
TARGET = $(AWKWARD_DIR)/t1
TARGETDEP = $(AWKWARD_DIRDEP)/t1
MAKEFILE = spacemake.mk

$(TARGETDEP): $(THISFILEDEP) $(AWKWARD_DIR_EXISTSDEP)
        cat "$(THISFILE)" >"$(TARGET)"

$(THISFILEDEP): $(AWKWARD_DIR_EXISTSDEP)
        echo "yo" >"$(THISFILE)"

$(AWKWARD_DIR_EXISTSDEP): $(MAKEFILE)
        @echo MAKEFILE = $(MAKEFILE)
        -mkdir "$(AWKWARD_DIR)"
        touch "$(AWKWARD_DIR_EXISTS)"

You can try it by placing it in a file called e.g. spacemake.mk, then run it with gmake -f spacemake.mk.

Upvotes: 0

Chris
Chris

Reputation: 101

If you look at this excellent write up: http://www.cmcrossroads.com/article/gnu-make-meets-file-names-spaces-them, the author suggests that this is mostly a difficult task. But his substitution functions could get you going in case you really can't avoid the spaces.

Putting this into your makefile would look like this (sorry if I changed some of your paths, but this works on my Cygwin installation):

LUAC            = luac

s+ = $(subst \\ ,+,$1)
+s = $(subst +,\ ,$1) 

SRC_DIR  = .
SOURCE  := stupid/naming\\ convention/a.lua 
SOURCE := $(call s+,$(SOURCE)) 

vpath .lua $(SRC_DIR)

OUT_DIR         = out/
OUTPUT          = $(patsubst %.lua, $(OUT_DIR)/%.luac, $(SOURCE))

all: $(call +s,$(OUTPUT))

$(OUT_DIR)/%.luac: %.lua
    $(LUAC) "$<"
    mv luac.out "$@"

.PHONY: all

I know that's not a complete answer, but maybe an encouragement that it actually is possible. But I agree with the other posters that if you can actually avoid spaces altogether, you will have a much easier life!

Upvotes: 0

lifus
lifus

Reputation: 8512

Unfortunately, GNU Make's functions that deal with space-separated list do not respect the escaping of the space. The only exception is wildcard.

Edit:

Here's my workaround:

LUAC            = luac

SRC_DIR         = .
SOURCE          =                                                      \
stupid/naming\ convention/a.lua                                        \
stupid/naming\ convention/very\ annoying/b.lua                         \

vpath .lua $(SRC_DIR)


OUT_DIR         = ../out/
OUTPUT          = $(patsubst %.lua,%.luac,$(SOURCE))


all: $(OUTPUT)

%.luac: %.lua
    $(LUAC) "$<"
    mv luac.out "$@""

.PHONY: all

I tried to output it first like that:

%.luac: %.lua
    @echo "$<"
    @echo "$@""

Output looks as follows:

stupid/naming convention/a.lua
../out/stupid/naming convention/a.luac
stupid/naming convention/very annoying/b.lua
../out/stupid/naming convention/very annoying/b.luac

Upvotes: 1

MadScientist
MadScientist

Reputation: 100946

The very short, but IMO ultimately correct, answer is that make (not just GNU make, but all POSIX-style make implementations) does not support pathnames containing whitespace. If you want to use make, your "anonymous developers" simply cannot use them. If they insist that this is an absolute requirement you should switch to a different build tool altogether, that does support whitespace in filenames.

Yes, it's barely possible to create a makefile that will work with filenames containing whitespace, but you will essentially have to rewrite all your makefiles from scratch, and you will not be able to use many of the features of GNU make so your makefiles will be long, difficult to read, and difficult to maintain.

Just tell them to get over themselves. Or if they really can't, try having them create their workspace in a pathname without any whitespace in the names, then create a symbolic link containing whitespace pointing to the real workspace (the other way around won't work in all situations).

Upvotes: 8

Related Questions