CODEWITHSUNDEEP
phpnestedreadabilityif-statement
Steven
Steven

Reputation: 25304

How to reduce the number of if-else statements in PHP?

I found that there are many if-else statements, especially nested if else statements, these statements make my code less readable. How to reduce the number of if else statements in PHP?

My tips are as follows: 1.Use a switch statement when it is suitable; 2.use exit() statement when it is feasible; 3. Use ternary statement when it is feasible;

Are there other tips that can reduce if else statements, especially nested if-else statements?

Upvotes: 10

Views: 7787

Answers (7)

Danish Mehmood
Danish Mehmood

Reputation: 151

You can reduce the number of if/else codes by using ternary operator or null coalescing operator like this:

Using the ternary operator: Variable = (Condition) ? (Statement1) : (Statement2);

$age = 20;
  print ($age >= 18) ? "Adult" : "Not Adult";

Output: Adult

By using the null coalescing operator:

// fetch the value of $_GET['user'] and returns 'not passed'
   // if username is not passed
   $username = $_GET['username'] ?? 'not passed';
   print($username);
   print("<br/>");

   // Equivalent code using ternary operator
   $username = isset($_GET['username']) ? $_GET['username'] : 'not passed';
   print($username);
   print("<br/>");
   // Chaining ?? operation
   $username = $_GET['username'] ?? $_POST['username'] ?? 'not passed';
   print($username);

Output:

not passed 
not passed 
not passed

Upvotes: -1

iWantSimpleLife
iWantSimpleLife

Reputation: 1954

There is an official academic method to refactor and simplify a lot of if conditions, called Karnaugh mapping.

It takes in multiple test conditions and attempts to assist in creating simplified if statements that cover all the required cases.

You can learn more about it from wiki here.

Upvotes: 11

smassey
smassey

Reputation: 5931

I work on a lot of code thats full of ever evolving business logic and needs to be modified every other day. Two tips that's certainly helped me keep up with the modifications are: avoid all else statements and return/exit as soon as possible. Never get into deep nesting -> create sub routines/functions.

Replacing all else statements with negated if statements makes your code much easier to read top to bottom (the proximity of the condtion and the code block):

# business logic block
if ( $condition ) {
    # do something
    # code code code
} else {
    # code code code
    return;
}

# refactored:
if ( ! $contition ) {
    # code code code
    return;
}
if ( $condition ) {
    # code code code 
}

Secondly, return/exit as soon as possible. My opinion of course, but I don't see the point in running through any extra conditions/tests when once you've already determined the result of the subroutine, especially when you would like to read the code top to bottom. Removing all ambiguity makes things simpler.

To conclude, I like to avoid using else especially in long lists of BL. Return as soon as you know the result. If the nesting level is more than 2, create sub routines/functions.

Upvotes: 3

streetparade
streetparade

Reputation: 32908

Use the ternary operator, refactor your code, write a function or a class which does all the necessary if else statements.

Upvotes: 4

BMBM
BMBM

Reputation: 16013

Try to use "early return" when possible in order to reduce nesting depth. Try to use boolean expression evaluation.

Example:

function foo($param)
{
    $ret = false;

    if(userIsLoggedIn()) {
        if(is_array($param)) {
            if($param['count'] > 0) {
                $ret = true;
            }
            else {
                $ret = false;
            }
        }        
    }

    return $ret;
}

You could rewrite this like:

function foo($param) 
{
    if(!userIsLoggedIn()) return false;
    if(!is_array($param)) return false;
    return $param['count'] > 0;
}

Upvotes: 23

NDM
NDM

Reputation: 6840

polymorphism could get rid of a few as well, allthough harder to implement to reduce if/else in PHP as it is not type safe...

Upvotes: 1

Jeff Paquette
Jeff Paquette

Reputation: 7127

Refactor your code into smaller work units. Too much conditional logic is a code-smell and usually indicates that your function needs to be refactored.

Upvotes: 23

Related Questions