CODEWITHSUNDEEP
arraysfilepascal
Alex Tsang
Alex Tsang

Reputation: 11

Pascal runtime error (range overrun) while reading array from file

I am trying to write a program to read a long list of book(1000 books),isbn etc but when the program runs, it shows range overrun the format of txt is

1
1234567890
ABC book
peter
20
2
1234567896
...

the code is:

const maxbk=1000;
type bookrecord = record
                    book_no:string;
                    isbn:string;
                    book_name:string;
                    author:string;
                    borrowed:string;
                    end;
var booklist : array[1..maxbk] of bookrecord;totalbook:integer;

procedure readbooklist(var bklist:array of bookrecord;var totalbk:integer);
var f:text;temp:string;code:integer;
begin
  totalbk:=0;
  assign(f,'bklist.txt');
  reset(f);
  while not eof(f) do
  begin
    readln(f,bklist[totalbk+1].book_no);
    readln(f,bklist[totalbk+1].isbn);
    readln(f,bklist[totalbk+1].book_name);
    readln(f,bklist[totalbk+1].author);
    readln(f,bklist[totalbk+1].borrowed);
    totalbk:=totalbk+1;
  end;
  close(f);
  writeln('read file done');
end;

begin
  readbooklist(booklist,totalbook);
end.

who can help to fix the problem??

Upvotes: 1

Views: 576

Answers (1)

lurker
lurker

Reputation: 58324

I think the problem is in your handling of the array parameter. Try this (highlighted in bold are the changes I've added):

const maxbk=1000;
type bookrecord = record
                    book_no:string;
                    isbn:string;
                    book_name:string;
                    author:string;
                    borrowed:string;
                    end;

var booklist : array[1..maxbk] of bookrecord; totalbook:integer;

procedure readbooklist(var bklist:array of bookrecord;var totalbk:integer);
var f:text;temp:string;code:integer;
begin
  totalbk:=Low(bklist);
  assign(f,'bklist.txt');
  reset(f);
  while not eof(f) do
  begin
    readln(f,bklist[totalbk].book_no);
    readln(f,bklist[totalbk].isbn);
    readln(f,bklist[totalbk].book_name);
    readln(f,bklist[totalbk].author);
    readln(f,bklist[totalbk].borrowed);
    totalbk:=totalbk+1;
  end;
  totalbk := totalbk - Low(bklist);
  close(f);
  writeln('read file done');
end;

begin
  readbooklist(booklist,totalbook);
end.

Also, a few choice spaces would help with readability (like a space after each comma and around assignment operators).

Note, too, that your code (and the changed code I'm providing) don't check for incomplete records in your input text file or properly check for blank lines, etc (e.g., invalid book_no values). You should attempt to add some code which makes it a little more resilient to problems in the input file. As others have pointed out, there are probably better ways to structure the input and read it as well.

Upvotes: 1

Related Questions