PHP form process error

Question

I've gotten help from this site lots of times, but this is the first time I need to post my own specifics.

I have a PHP registration form, and I'm sure it's a minor problem, but I don't know exactly what I need to fix. So, I'd appreciate somebody glancing over it.

    
";
    echo $error."

";
    echo "Please go back and fix these errors.

";
    die();
}

// validation expected data exists
if(!isset($_POST['Agency']) ||
    !isset($_POST['AgencyPhone'])) {
    died('We are sorry, but there appears to be a problem with the form you submitted.');      
}

$Agency = $_POST['Agency']; // required
$AgencyPhone = $_POST['AgencyPhone']; // required
$contact = $_POST['contact']; // not required
...this goes on for quite some time...
$Zip = $_POST['Zip']; // not required

$error_message = "";
$string_exp = "/^[A-Za-z .'-]+$/";
if(!preg_match($string_exp,$Agency)) {
$error_message .= 'The Agency Name you entered does not appear to be valid.
';
}
if(strlen($AgencyPhone) < 2) {
$error_message .= 'The Agency Phone you entered does not appear to be valid.
';
}
$email_message = "You received a message from your site!

";

function clean_string($string) {
  $bad = array("content-type","bcc:","to:","cc:","href");
  return str_replace($bad,"",$string);
}

$email_message="
Class: ".$contact."
Dates: ".$Dates." through ".$through."
Location: ".$Location."
Fee: ".$Fee.", ".$Rate."

Students:
1: ".$Last1.", ".$First1.", ".$Email1.", ".$Phone1."
;
2: ".$Last2.", ".$First2.", ".$Email2.", ".$Phone2."
;
3: ".$Last3.", ".$First3.", ".$Email3.", ".$Phone3."
;
4: ".$Last4.", ".$First4.", ".$Email4.", ".$Phone4."
;
5: ".$Last5.", ".$First5.", ".$Email5.", ".$Phone5."
;

Agency: ".$Agency.";
Mailing: ".$Mailing.";
City: ".$City.";
Zip: ".$Zip.";
Agency Phone: ".$AgencyPhone.";
"

// create email headers
$headers = 'From: '.$email_from."
".
'Reply-To: '.$email_from."
" .
'X-Mailer: PHP/' . phpversion();
@mail($email_to, $email_subject, $email_message, $headers); 
?>

...Then, I have the content of the process page...

So, the error is in this line.

$headers = 'From: '.$email_from."
".

Or, an error is, anyway. What's missing, or what do I need to add? Thanks for whatever help you can give. I really appreciate it.

My form is:


  Enter Class Date, Location and Fee

        for which you are registering:
      Dates:
        
      through
      
      
      Location: 
        
      
      
      
          
          Registration Fee:
              
per student
          
      
      Please fill in fields below.

        (Confirmation e-mail will be forwarded to attendee and Registrant Agency upon receipt.)
      Student Information:
      
        
          Last
          First
          E-mail
          Phone
        
        
          
            
          
          
            
          
          
            
          
          
            
          
        
        
          
            
          
          
            
          
          
            
          
          
            
          
        
        
          
            
          
          
            
          
          
            
          
          
            
          
        
        
          
            
          
          
            
          
          
            
          
          
            
          
        
        
          
            
          
          
            
          
          
            
          
          
            
          
        
      
      Registrant Agency Information:
      Agency Name*:
        
      
      Mailing Address:
        
      
      City:
         
        Zip: 
        
      
      Phone*:

I also had a set of radio buttons (named Rate) and check boxes (named Fee) that I deleted out of this. One problem at a time...

Funk Forty Niner · Accepted Answer

NEW VERSION (edit)

Previous form processor is located under this one.

There were a few errors.

It was in fact a misplaced semi-colon in Agency Phone: ".$AgencyPhone.";" which should have read as Agency Phone: ".$AgencyPhone.""; and should have been on the outside instead of being "sandwiched", as it were. The OP had it as ";" when it needed to be "";

Another error was that the email variable was not defined. Since the form did not contain an input field called "email", replaced if(isset($_POST['email'])) { with if(isset($_POST['submit'])) {

A foreach was also added to eleviate the work to define each of the form's fields/variables.


";
    echo $error."

";
    echo "Please go back and fix these errors.

";
    die();
}

// validation expected data exists
if(!isset($_POST['Agency']) ||
    !isset($_POST['AgencyPhone'])) {
    died('We are sorry, but there appears to be a problem with the form you submitted.');      
}

$Agency = $_POST['Agency']; // required
$AgencyPhone = $_POST['AgencyPhone']; // required
$contact = $_POST['contact']; // not required

$Zip = $_POST['Zip']; // not required

$error_message = "";
$string_exp = "/^[A-Za-z .'-]+$/";
if(!preg_match($string_exp,$Agency)) {
$error_message .= 'The Agency Name you entered does not appear to be valid.
';
}
if(strlen($AgencyPhone) < 2) {
$error_message .= 'The Agency Phone you entered does not appear to be valid.
';
}

function clean_string($string) {
  $bad = array("content-type","bcc:","to:","cc:","href");
  return str_replace($bad,"",$string);
}

// This is where all the MAGIC happens
foreach ($_POST as $key=>$value) {
    $email_message.=$key.": " . $value . "
";
}

$headers  = 'MIME-Version: 1.0' . "
";

$headers .= 'From: ' . $email_from . "
" . 'Reply-To: ' . $email_from . "
" . 'X-Mailer: PHP/' . phpversion();

if(mail($email_to, $email_subject, $email_message, $headers))
{
  echo "Mail Sent Successfully";


}else{
  echo "Mail Not Sent";
}

?>

OLD VERSION

Give this a try:


";
    echo $error."

";
    echo "Please go back and fix these errors.

";
    die();
}

// validation expected data exists
if(!isset($_POST['Agency']) ||
    !isset($_POST['AgencyPhone'])) {
    died('We are sorry, but there appears to be a problem with the form you submitted.');      
}

$Agency = $_POST['Agency']; // required
$AgencyPhone = $_POST['AgencyPhone']; // required
$contact = $_POST['contact']; // not required

$Zip = $_POST['Zip']; // not required

$error_message = "";
$string_exp = "/^[A-Za-z .'-]+$/";
if(!preg_match($string_exp,$Agency)) {
$error_message .= 'The Agency Name you entered does not appear to be valid.
';
}
if(strlen($AgencyPhone) < 2) {
$error_message .= 'The Agency Phone you entered does not appear to be valid.
';
}
// $email_message = "You received a message from your site!

";

function clean_string($string) {
  $bad = array("content-type","bcc:","to:","cc:","href");
  return str_replace($bad,"",$string);
}

$email_message="
Class: ".$contact."
Dates: ".$Dates." through ".$through."
Location: ".$Location."
Fee: ".$Fee.", ".$Rate."

Students:
1: ".$Last1.", ".$First1.", ".$Email1.", ".$Phone1."
;
2: ".$Last2.", ".$First2.", ".$Email2.", ".$Phone2."
;
3: ".$Last3.", ".$First3.", ".$Email3.", ".$Phone3."
;
4: ".$Last4.", ".$First4.", ".$Email4.", ".$Phone4."
;
5: ".$Last5.", ".$First5.", ".$Email5.", ".$Phone5."
;

Agency: ".$Agency.";
Mailing: ".$Mailing.";
City: ".$City.";
Zip: ".$Zip.";
Agency Phone: ".$AgencyPhone."
";

// create email headers
// $headers = 'From: $email_from' ."
" . 'Reply-To: $email_from' . "
" . 'X-Mailer: PHP/' . phpversion();

$headers  = 'MIME-Version: 1.0' . "
";

// You can comment out the line below if sending an HTML based message
//$headers .= 'Content-type: text/html; charset=iso-8859-1' . "
";

$headers .= 'From: ' . $email_from . "
" . 'Reply-To: ' . $email_from . "
" . 'X-Mailer: PHP/' . phpversion();

// Previous mail function with @ symbol
// @mail($email_to, $email_subject, $email_message, $headers); 
  // mail($email_to, $email_subject, $email_message, $headers); 

if(mail($email_to, $email_subject, $email_message, $headers))
{
echo "Mail Sent Successfully";

}else{
echo "Mail Not Sent";
}

?>

PHP form process error

Answers (1)

NEW VERSION (edit)

Previous form processor is located under this one.

OLD VERSION

Related Questions