CODEWITHSUNDEEP
c++arrayssegmentation-fault
Mayank
Mayank

Reputation: 1521

Segmentation fault on large array sizes

The following code gives me a segmentation fault when run on a 2Gb machine, but works on a 4GB machine.

int main()
{
   int c[1000000];
   cout << "done\n";
   return 0;
}

The size of the array is just 4Mb. Is there a limit on the size of an array that can be used in c++?

Upvotes: 139

Views: 135294

Answers (7)

Gunther Piez
Gunther Piez

Reputation: 30449

In C or C++ local objects are usually allocated on the stack. You are allocating a large array on the stack, more than the stack can handle, so you are getting a stackoverflow.

Don't allocate it local on stack, use some other place instead. This can be achieved by either making the object global or allocating it on the global heap. Global variables are fine, if you don't use the from any other compilation unit. To make sure this doesn't happen by accident, add a static storage specifier, otherwise just use the heap.

This will allocate in the BSS segment, which is a part of the heap. Since it's in static storage, it's zero initialized if you don't specify otherwise, unlike local variables (automatic storage) including arrays.

static int c[1000000];
int main()
{
   cout << "done\n";
   return 0;
}

A non-zero initializer will make a compiler allocate in the DATA segment, which is a part of the heap too. (And all the data for the array initializer will take space in the executable, including all the implicit trailing zeros, instead of just a size to zero-init in the BSS)

int c[1000000] = {1, 2, 3};
int main()
{
   cout << "done\n";
   return 0;
}

This will allocate at some unspecified location in the heap:

int main()
{
   int* c = new int[1000000];  // size can be a variable, unlike with static storage
   cout << "done\n";
   delete[] c;            // dynamic storage needs manual freeing
   return 0;
}

Upvotes: 63

Charles Salvia
Charles Salvia

Reputation: 53329

You're probably just getting a stack overflow here. The array is too big to fit in your program's stack region; the stack growth limit is usually 8 MiB or 1 MiB for user-space code on most mainstream desktop / server OSes. (Normal C++ implementations use the asm stack for automatic storage, i.e. non-static local variables arrays. This makes deallocating them happen for free when functions return or an exception propagates through them.)

If you dynamically allocate the array you should be fine, assuming your machine has enough memory.

int* array = new int[1000000];    // may throw std::bad_alloc

But remember that this will require you to delete[] the array manually to avoid memory leaks, even if your function exits via an exception. Manual new/delete is strongly discouraged in modern C++, prefer RAII.

A better solution would be to use std::vector<int> array (cppreference). You can reserve space for 1000000 elements, if you know how large it will grow. Or even resize it to default-construct them (i.e. zero-initialize the memory, unlike when you declare a plain C-style array with no initializer), like std::vector<int> array(1000000)

When the std::vector object goes out of scope, its destructor will deallocate the storage for you, even if that happens via an exception in a child function that's caught by a parent function.

Upvotes: 157

Rahul Bhardwaj
Rahul Bhardwaj

Reputation: 1

there can be one more way that worked for me! you can reduce the size of array by changing its data type:

    int main()
        {
        short c[1000000];
        cout << "done\n";
        return 0;
        }

or

  int main() 
  {
      unsigned short c[1000000];
      cout << "done\n";
      return 0;
  }

Upvotes: 0

Arty
Arty

Reputation: 16757

Your plain array is allocated in stack, and stack is limited to few magabytes, hence your program gets stack overflow and crashes.

Probably best is to use heap-allocated std::vector-based array which can grow almost to size of whole memory, instead of your plain array.

Try it online!

#include <vector>
#include <iostream>

int main() {
   std::vector<int> c(1000000);
   std::cout << "done\n";
   return 0;
}

Then you can access array's elements as usual c[i] and/or get its size c.size() (number of int elements).

If you want multi-dimensional array with fixed dimensions then use mix of both std::vector and std::array, as following:

Try it online!

#include <vector>
#include <array>
#include <iostream>

int main() {
   std::vector<std::array<std::array<int, 123>, 456>> c(100);
   std::cout << "done\n";
   return 0;
}

In example above you get almost same behavior as if you allocated plain array int c[100][456][123]; (except that vector allocates on heap instead of stack), you can access elements as c[10][20][30] same as in plain array. This example above also allocates array on heap meaning that you can have array sizes up to whole memory size and not limited by stack size.

To get pointer to the first element in vector you use &c[0] or just c.data().

Upvotes: 1

RSFalcon7
RSFalcon7

Reputation: 2311

Also, if you are running in most UNIX & Linux systems you can temporarily increase the stack size by the following command:

ulimit -s unlimited

But be careful, memory is a limited resource and with great power come great responsibilities :)

Upvotes: 22

Narek
Narek

Reputation: 39881

Because you store the array in the stack. You should store it in the heap. See this link to understand the concept of the heap and the stack.

Upvotes: 3

rerun
rerun

Reputation: 25505

You array is being allocated on the stack in this case attempt to allocate an array of the same size using alloc.

Upvotes: 3

Related Questions