CODEWITHSUNDEEP
rubyarrays
Max Rose-Collins
Max Rose-Collins

Reputation: 1924

Add to an array from within a loop using Ruby

I am having a few problems adding to an array from within a loop. It only adds the last results to the array and loses the previous 9 sets.

I think I have to create a new array inside of the loop and then add the new one to the previous. I'm just not sure how I go about doing that.

array = Array.new

10.times do
  array2 = Array.new
  pagenum = 0
  results = Nokogiri::HTML(open("#{url}#{pagenum}"))
  results.css("div").each do |div|
    array.push div.inner_text
  end
  pagenum + 10
  array.concat(array2)
end

Upvotes: 0

Views: 840

Answers (1)

falsetru
falsetru

Reputation: 369424

You are fetching same page (0) 10 times.

10.times do
  ...
  pagenum = 0 # <--------
  results = Nokogiri::HTML(open("#{url}#{pagenum}"))
  ...
end

Try following:

array = Array.new
10.times do |pagenum|
  results = Nokogiri::HTML(open("#{url}#{pagenum}"))
  array += results.css("div").map(&:inner_text)
end

Upvotes: 2

Related Questions