CODEWITHSUNDEEP
c#multithreadingtask-parallel-library
trailmax
trailmax

Reputation: 35106

Task.Delay() not behaving as expected

Task.Delay() not behaving as expected or rather I'm not understanding what it is supposed to do. I'm trying to get my head around Tasks in C# and how to replace Threads in my implementation.

What I'm trying to do is something like this:

I've got that implemented with Threads fine, but all cool kids say I should be using Task, and don't touch Thread.

So for the code I have this (Ignore [Test] - this just a convenient way to try out things)

    [Test]
    public void ChattyTask()
    {
        var chattyTask = new Task(ChattyWriter);
        chattyTask.Start();
        chattyTask.Wait();
    }

    public void ChattyWriter()
    {
        int count = 0;
        while (true)
        {
            var message = String.Format("Chatty Writer number {0}", count);
            Trace.WriteLine(message);
            count++;
            Task.Delay(1000);

            if (count >= 20)
            {
                break;
            }
        }
    }

When I run this, the test finishes in milliseconds, not in 20 seconds as I would expect. If I replace Task.Delay() with Thread.Sleep(), everything works as expected and I get the printout once a second. I have tried adding async and await into ChattyWriter(), but not only it did not add a 1 second delay, it only printed only one line instead of 20.

What am I doing wrong?

Probably It'll help to describe what I'm doing: my project works with external API (RESTful) and after I request some tasks to happen, I need to poll the API to check if the task has been completed. External tasks can be long running: 1-15 minutes. So I need some delay between checking for completion. And there could be many different concurrent processes executed with multiple external tasks. I understand, that if I use Thread.Sleep() when polling, other processes on the same Thread will be blocked for no good reason.

Upvotes: 34

Views: 48306

Answers (3)

slfan
slfan

Reputation: 9129

Task.Delay returns a Task object on which you have to wait. Otherwise the following code will be executed immediately. Therfore you have to declare your method as async. Then you can await Task.Delay

public async Task ChattyWriter()
{
    int count = 0;
    while (true)
    {
        var message = String.Format("Chatty Writer number {0}", count);
        Trace.WriteLine(message);
        count++;
        await Task.Delay(1000);
           ...
    }
}

You have to interrupt your calling thread somehow. The unit test would terminate and the background thread as well. But if you call this method from the UI, the UI will not get blocked.

By calling Wait on an asynchronous method you will end up with a deadlock. See here for more information.

Upvotes: 60

Pandacoon
Pandacoon

Reputation: 35

Task.Delay() actually creates a task, so you just need to wait for it.

Try this

        public static void ChattyWriter()
    {
        int count = 0;
        while (true)
        {
            var message = String.Format("Chatty Writer number {0}", count);
            Console.WriteLine(message);
            count++;
            var t = Task.Delay(1000);
            t.Wait();

            if (count >= 20)
            {
                break;
            }
        }
    }

Upvotes: 2

Cristian Lupascu
Cristian Lupascu

Reputation: 40526

Task.Delay(1000); creates an async task that will complete after a second, but the execution of the current method will continue in parallel.

In order to wait for the task to complete first, you could replace

Task.Delay(1000);

with

Task.Delay(1000).Wait();

Upvotes: 32

Related Questions