CODEWITHSUNDEEP
javabooleansyntax-error
Kyle
Kyle

Reputation: 13

How to compare three boolean values

Compare three boolean values and display the first one that is true.

Hey guys, I am trying to write a program that compares three boolean values and displays the first true one. I am comparing three words for their length, and it will display the longest. The error that I am getting is that my else tags aren't working. Take a look at the code.

//Check which word is bigger
    if (len1 > len2)
        word1bt2 = true;

    if (len2 > len3)
        word2bt3 = true;

    if (len1 > len3)
        word1bt3 = true;

    //Check which word is the longest
    if (word1bt2 == true && word1bt3 == true);
        System.out.println(wor1);
        else if (word2bt3 == true);
        System.out.println(wor2);
        else System.out.println(wor3);

I have set boolean values for word1bt2, word2bt3 and word1bt3. In eclipse, I am getting a syntax error under the elses in my code above. Any help would be great!

Upvotes: 0

Views: 4620

Answers (5)

Konstantin Yovkov
Konstantin Yovkov

Reputation: 62884

Remove the ; and change it with brackets {}.

if (word1bt2 && word1bt3) {
      System.out.println(wor1);
} else if (word2bt3) {
      System.out.println(wor2);
} else {
      System.out.println(wor3);
}

Upvotes: 1

OldCurmudgeon
OldCurmudgeon

Reputation: 65889

How to compare three boolean values?

Dont!

If you find yourself needing to compare three variable you may as well cater for any number of variables immediately - there's no point hanging around - do it properly straight away.

public String longest(Iterator<String> i) {
  // Walk the iterator.
  String longest = i.hasNext() ? i.next() : null;
  while (i.hasNext()) {
    String next = i.next();
    if (next.length() > longest.length()) {
      longest = next;
    }
  }
  return longest;
}

public String longest(Iterable<String> i) {
  // Walk the iterator.
  return longest(i.iterator());
}

public String longest(String... ss) {
  // An array is iterable.
  return longest(ss);
}

Upvotes: 2

BackSlash
BackSlash

Reputation: 22243

if (word1bt2 == true && word1bt3 == true);

Is wrong, you need to remove the semicolon:

if (word1bt2 == true && word1bt3 == true)

Same for the elses

else (word2bt3 == true);

Is wrong too, it should be

else if (word2bt3 == true)

Side note: boolean values can be used as condition, so your if statements should be

if (word1bt2 && word1bt3) // The same as if (word1bt2 == true && word1bt3 == true)

Upvotes: 3

upog
upog

Reputation: 5526

try this, if lenght are equal then s1 is considered as Bigger. Also i have not added null check

 public class Test {
            public static void main(String[] args) {

            String word1 = "hi";
            String word2 = "Hello";
            String word3 = "Hell";
            String Bigger = null;
            if(word1.length() >= word2.length() && word1.length() >= word3.length() ){
                Bigger = word1;
            }else if(word2.length() >= word1.length() && word2.length() >= word3.length()){
                Bigger = word2;
            }else if(word3.length() >= word2.length() && word3.length() >= word1.length()){
                Bigger = word3;
            }
            System.out.println(Bigger);

        }

    }

Upvotes: 0

ppeterka
ppeterka

Reputation: 20736

Issue with the else blocks: use {} insteaad of () to enclose instructions...

Remove the ; at the first if!!!!! - Quite common mistake, with very puzzling results!

//Check which word is the longest
if (word1bt2 == true && word1bt3 == true) { //leave ; and always add bracket!
    System.out.println(wor1);
}
else if(word2bt3 == true)
{
    System.out.println(wor2);
}
else {
    System.out.println(wor3);
}
  • if you need a condition in an else branch, you have to use if again - plain else won't have such a feature...
  • ALWAYS use brackets for bodies of if statements, loops, etc!!!
  • Be extremely careful NOT to use ; in the lines that don't behave well with it:
    • if statements
    • for loops
    • while() {...} loops' while statement

Upvotes: 0

Related Questions