CODEWITHSUNDEEP
ruby-on-railsrubyruby-on-rails-4
Pete
Pete

Reputation: 2246

Rails 4 Strong Parameters : can I 'exclude' / blacklist attributes instead of permit / whitelist?

I'm migrating a Rails 3 app to Rails 4 and I'm in the process of converting attr_accessible properties to strong parameters in the controller. The API Documentation shows how to 'permit' attributes:

def person_params
  params.require(:person).permit(:name, :age)
end

However the vast majority of my attributes are mass-assignment safe. It's only a few attributes like :account_id and :is_admin that I need to blacklist.

Is it possible to blacklist attributes instead of whitelisting almost every attribute? E.g something like:

def user_params
  params.require(:user).exclude(:account_id, :is_admin)
end

Upvotes: 15

Views: 13852

Answers (4)

snowangel
snowangel

Reputation: 3462

From the docs: yes, you can, with except, which "returns a new ActionController::Parameters instance that filters out the given keys":

params = ActionController::Parameters.new(a: 1, b: 2, c: 3)
params.except(:a, :b) # => <ActionController::Parameters {"c"=>3} permitted: false>
params.except(:d)     # => <ActionController::Parameters {"a"=>1, "b"=>2, "c"=>3} permitted: false>

Upvotes: 3

Mike Szyndel
Mike Szyndel

Reputation: 10592

I think you shouldn't really do that for reasons outlined by @Damien, but heres a solution I just found.

params.require(:user).except!(:account_id, :is_admin).permit!

This will remove :account_id, :is_admin from hash and permit all other parameters. But again - this is potentially insecure.

Why this works? Because ActionController::Parameters inherits from Hash!

Update 4th July 2016

In Rails 5 this probably doesn't work anymore as per upgrade guide

ActionController::Parameters No Longer Inherits from HashWithIndifferentAccess

Upvotes: 27

Oleg Haidul
Oleg Haidul

Reputation: 3732

Whitelisting is more secure.

But u can try: In model:

self.permitted_params
  attribute_names - ["is_admin"]
end

In Controller:

def user_params
  params.require(:user).permit(*User.permitted_params)
end

Upvotes: 4

Damien MATHIEU
Damien MATHIEU

Reputation: 32627

No, this is not possible.
Blacklisting attributes would be a security issue, since your codebase can evolve, and other attributes, which should be blacklisted can be forgotten in the future.

Adding all your whitelisted attributes might seem like a complicated thing when implementing it.
However, it's the only way of keeping your application secure and avoiding disturbing things.

Upvotes: 4

Related Questions