CODEWITHSUNDEEP
javascriptnode.jsexpress
DarkLeafyGreen
DarkLeafyGreen

Reputation: 70406

Node.js method does not return any response, pending request

Simple upload method using node.js+express.js:

upload: function(req, res, next){
    //go over each uploaded file
    async.each(req.files.upload, function(file, cb) {
        async.auto({
            //create new path and new unique filename
            metadata: function(cb){
                //some code...
               cb(null, {uuid:uuid, newFileName:newFileName, newPath:newPath});
            },
            //read file
            readFile: function(cb, r){
               fs.readFile(file.path, cb);
            },
            //write file to new destination
            writeFile: ['readFile', 'metadata', function(cb,r){
                fs.writeFile(r.metadata.newPath, r.readFile, function(){
                    console.log('finished');
                });   
            }]
        }, function(err, res){
            cb(err, res);
        });
    }, function(err){
        res.json({success:true});
    });

   return;
}

The method iterates each uploaded file, creates a new filename and writes it to a given location set in metadata.

console.log('finished');

is fired when writing is finished, however the client never receives a response. After 2 minutes the request is cancled, however the file was uploaded.

Any ideas why this method does not return any response?

Upvotes: 1

Views: 1612

Answers (1)

Elias Van Ootegem
Elias Van Ootegem

Reputation: 76395

You're using readFile, which is async, too, and works like this:

fs.readFile('/path/to/file',function(e,data)
{
    if (e)
    {
        throw e;
    }
    console.log(data);//file contents as Buffer
});

I you could pass a reference to a function here, to take care of this, but IMO, it'd be way easier to simply use readFileSync, which returns the Buffer directly, and can be passed to writeFile without issues:

fs.writeFile(r.metadata.newPath, r.readFileSync, function(err)
{
    if (err)
    {
        throw err;
    }
    console.log('Finished');
});

Check the docs for readFile and writeFile respectively

Upvotes: 1

Related Questions