Reputation: 14491
When I want to squash some commits by interactive rebase
:
git rebase -i HEAD~3
And then:
pick cbd03e3 Final commit (signed)
s f522f5d bla-bla-bla (signed)
s 09a7b7c bla-bla (signed)
# Rebase c2e142e..09a7b7c onto c2e142e
...
The final commit haven't gpg-signature despite that all of those commits have same signature. Is it possible to retain commit gpg-signature after interactive rebase squash?
Upvotes: 39
Views: 19244
Reputation: 21259
There was one method that didn't get mentioned yet, but in effect it equates to an interactive rebase with edit
on each commit to-be-signed and a manual amend/commit (with -S
), but with a predetermined command and in an automated fashion:
git rebase --exec 'git commit --amend --no-edit -S' HEAD~3
The -i
(--interactive
) is implied with --exec
given, according to the documentation, so it's not given above.
Here we rebase against HEAD~3
as in the question, and git commit --amend --no-edit -S
each of the commits. This should usually ask for the passphrase of the PGP key once and then rush through for the remaining commits.
NB: it should go without saying, but since it was commented: just as with the other methods you'll only want to do that with your own commits. Remove the --no-edit
and you'll be dropped into the editor, showing (in a comment at the bottom) what changes you're dealing with. This way you can verify that the commits are yours (unless you already did by way of git log
or so).
Arguably to tell Git to sign when you haven't configured it globally, you could probably also use git -c commit.gpgSign=true
(or other related configuration options) in the command passed via --exec
.
Upvotes: 1
Reputation: 8782
One option is to set a commit.gpgSign
setting to true
. This will always sign the commits including the rebased commits.
To do it locally in a repo:
git config commit.gpgSign true
To do it globally:
git config --global commit.gpgSign true
Upvotes: 6
Reputation: 1323035
To reinforce the fact you don't keep signature on rebased commits, git 2.9.x+ (Q3 2016) will clearly state that a git pull --rebase
would not check signature (since the rebase part would lost them)
See commit c57e501 (20 May 2016) by Alexander Hirsch (``).
(Merged by Junio C Hamano -- gitster
-- in commit 73bc4b4, 20 Jun 2016)
pull
: warn on--verify-signatures
with--rebase
git-pull
silently ignores the--verify-signatures
option when running--rebase
, potentially leaving users in the belief that the rebase operation would check for valid GPG signatures.Implementing
--verify-signatures
forgit rebase
was talked about, but doubts for a valid workflow rose up. Since you usually merge other's branches into your branch you might have an interest that their side has a valid GPG signature.Rebasing, on the other hand, is to rebuild your branch on top of other's work, in order to push the result back, and it is too late to reject their work even if you find their commits lack acceptable signature.
Let's warn users that the
--verify-signatures
option is ignored during "pull --rebase
"; users do not wonder what would happen if their commits lack acceptable signature that way.
Upvotes: 6
Reputation: 800
Like Cupcake stated, you can't retain the old signature from the unsquashed commits, but you can sign the new squashed commit if you rebase like this:
git rebase --interactive [email protected] HEAD~4
Adding [email protected]
as an argument will sign the final squashed commit.
Upvotes: 66
Reputation:
It doesn't make sense that you would be able to. The whole point of a gpg signature is to verify that code hasn't been tampered with. If you could keep the signature after modifying the history, that would defeat the whole purpose.
I don't currently sign my Git code with gpg so I don't know the exact details, but I guess it probably hashes the final commit object of a tree. When you rebase like in your example, the Final commit
will have a different sha1 ID, so it's not the same object as before the rebase, so having the same gpg signature is probably impossible, and like I said, it wouldn't make sense.
Upvotes: 16