CODEWITHSUNDEEP
c#c#-4.0recursion
Hans Rudel
Hans Rudel

Reputation: 3611

Recursion in place of multiple nested for loops?

Im having some issues with trying to update a nested for loop to use recursion instead. Is it possible to access the a,b and c variables from the earlier for loops when using recursion? Below is a simple example of what im trying to convert into a recursive call.

for(int a= 0; a < 10; a++)
{
    for(int b = 0; b < 20; b++)
    {
        for(int c = 0; c < 10; c++)
        {
            int[] indexes = new int[3]{a,b,c}
            collection.add(indexes);
        }
    }
}

EDIT: The solution needs to be able to be adjusted at runtime, such that a user can select how many levels are required.

Upvotes: 4

Views: 4545

Answers (6)

FreddyFlares
FreddyFlares

Reputation: 473

This solution takes an Action for the work to be done at the leafs:

void ForEachCombo(int from, int to, int nrLevels, Action<int[]> action)
{
    int[] d = new int[nrLevels];
    InnerFor(from, to, 0);
    void InnerFor(int from, int to, int level)
    {
        if (level == nrLevels)
            action(d);
        else
            for (d[level] = from; d[level] <= to - nrLevels + level + 1; d[level]++)
                InnerFor(d[level] + 1, to, level + 1);
    }
}

Use like this:

ForEachCombo(0, 9, 3, (d) =>
{
    Console.WriteLine(string.Join(", ", d));
});

// Output
0, 1, 2
0, 1, 3
0, 1, 4
0, 1, 5
...
6, 7, 9
6, 8, 9
7, 8, 9
//

If you want to you can save a level of recursion by writing like this:

void ForEachCombo(int from, int to, int nrLevels, Action<int[]> action)
{
    int[] d = new int[nrLevels];
    InnerFor(from, to, 0);
    void InnerFor(int from, int to, int level)
    {
        if (level == nrLevels - 1)
            for (d[level] = from; d[level] <= to - nrLevels + level + 1; d[level]++)
                action(d);
        else
            for (d[level] = from; d[level] <= to - nrLevels + level + 1; d[level]++)
                InnerFor(d[level] + 1, to, level + 1);
    }
}

Upvotes: 0

Cold
Cold

Reputation: 797

Well, i think that if u resolve this problem using recursion, it will consume more memory and other resources!

But there is my suggestion:

private void FunctionName(int a, int b, int c, List<int[]> list)
{
    if (a<10)
    { 
       if (b<20)
       {
           if (c<10)
           {
               list.Add(new[] { a, b, c });
               c++;
               FunctionName(a,b,c,list);
            }
            else
            {
                 c=0;
                 b++;
                 FunctionName(a,b,c,list);
            }
       }
       else
       {
          b=0;
          a++;
          FunctionName(a,b,c,list);
       }
    }
 }

You call like this : FunctionName(0,0,0,list).

Hope it works! ^^

Upvotes: 1

Douglas
Douglas

Reputation: 54877

Here's a recursive solution (using a functional programming style):

public static IEnumerable<IEnumerable<int>> GetCombinations(IEnumerable<int> limits)
{
    if (limits.Any() == false)
    {
        // Base case.
        yield return Enumerable.Empty<int>();
    }
    else
    {
        int first = limits.First();
        IEnumerable<int> remaining = limits.Skip(1);
        IEnumerable<IEnumerable<int>> tails = GetCombinations(remaining);

        for (int i = 0; i < first; ++i)
            foreach (IEnumerable<int> tail in tails)
                yield return Yield(i).Concat(tail);
    }
}

// Per http://stackoverflow.com/q/1577822
public static IEnumerable<T> Yield<T>(T item)
{
    yield return item;
}

Sample use:

var sequences = GetCombinations(new [] { 5, 3, 2, 4 /* ... */ });
foreach (var sequence in sequences)
    Console.WriteLine(string.Join(", ", sequence));

/* Output:
0, 0, 0, 0
0, 0, 0, 1
0, 0, 0, 2
0, 0, 0, 3
0, 0, 1, 0
0, 0, 1, 1
0, 0, 1, 2
0, 0, 1, 3
0, 1, 0, 0
0, 1, 0, 1
0, 1, 0, 2
... */

For OP's specific scenario (adding arrays to collection):

var sequences = GetCombinations(new [] { 10, 20, 10 });
collection.AddRange(sequences.Select(s => s.ToArray()));

Upvotes: 10

Alessandro D&#39;Andria
Alessandro D&#39;Andria

Reputation: 8868

Ok, try with this

static void AddToCollectionRecursive(
    List<int[]> collection,
    params int[] counts)
{
    AddTo(collection, new List<int>(), counts, counts.Length - 1);
}

static void AddTo(
    List<int[]> collection,
    IEnumerable<int> value,
    IEnumerable<int> counts,
    int left)
{
    for (var i = 0; i < counts.First(); i++)
    {
        var list = value.ToList();

        list.Add(i);

        if (left == 0)
        {
            collection.Add(list.ToArray());
        }
        else
        {
            AddTo(collection, list, counts.Skip(1), left - 1);
        }
    }
}

Usage is like this AddToCollectionRecursive(collection, 10, 20, 10);.

Upvotes: 5

gesus
gesus

Reputation: 471

something like this will work:

public void CreateIndexes(int a, int b, int c, Collection collection)
{
    if(c == 10) {b++; c = 0;}
    if(b == 20) {a++; b = 0;}
    if(a == 10) return;

    int[] indexes = new int[3]{a,b,c}
    collection.add(indexes);
    c++;

    CreateIndexes(a, b, c, collection);
}

Upvotes: 2

DaveDev
DaveDev

Reputation: 42185

Off the top of my head, i.e. not tested, something like this might work:

    List<int[]> collection = new List<int[]>();
    private void AddValues(int a, int b, int c)
    {

        collection.Add(new[] { a, b, c });

        if (c < 10)
        {
            c++;
            AddValues(a, b, c);
        }

        if (b < 20)
        {
            b++;
            c = 0;
            AddValues(a, b, c);   
        }

        if (a < 10)
        {
            a++;
            b = 0;
            c = 0;
            AddValues(a, b, c);
        }
    }

Start it by calling:

AddValues(0, 0, 0);

Upvotes: 1

Related Questions