Spring mvc controller bean configuration

Question

I am working on a project using Spring mvc and I counter a problem that a handler is auto generated when I start the server.

Here is the code:

Controller

@Controller
@RequestMapping(value="userstory/{projectid}/{sprintid}/")
@SessionAttributes(value = "user")
public class UserstoryController {
    private ISprintService sprintService;
    private IUserStoryService userStoryService;
    private IProjectService projectService;
    private IBurnDownChartService burnDownChartService;
    private ITaskService taskService;

    public void setSprintService(ISprintService sprintService) {
        this.sprintService = sprintService;
    }

    public void setUserStoryService(IUserStoryService userStoryService) {
        this.userStoryService = userStoryService;
    }

    public void setProjectService(IProjectService projectService) {
        this.projectService = projectService;
    }

    public void setBurnDownChartService(IBurnDownChartService burnDownChartService) {
        this.burnDownChartService = burnDownChartService;
    }

    public void setTaskService(ITaskService taskService) {
        this.taskService = taskService;
    }

    @RequestMapping(method=RequestMethod.GET)
    public String getUserstoryPage(@PathVariable("projectid") int pid, @PathVariable("sprintid") int sid,  @ModelAttribute("user") SerializablePerson user) {
        if (user.getId() != 0) {
            Project p = this.projectService.findProjectById(pid);
            if (p == null) {
                throw new ResourceNotFoundException(pid);
            }
            if (user.getRole().equals("User")) {
                return "userstory/user_userstory";
            }
            else {
                return "userstory/admin_userstory";
            }
        }
        return "redirect:../../../login";
    }

}

beans.xml

I copy all the beans to show that there is no userstoryController mapped.

web.xml



  
    characterEncodingFilter
    org.springframework.web.filter.CharacterEncodingFilter
    
      encoding
      UTF-8
    
    
      forceEncoding
      true
    
  
  
    characterEncodingFilter
    /*
  
  
    UrlRewriteFilter
    org.tuckey.web.filters.urlrewrite.UrlRewriteFilter
  
  
    UrlRewriteFilter
    /*
  
  
    scrumit
    org.springframework.web.servlet.DispatcherServlet
    
      contextConfigLocation
      /WEB-INF/spring/app-config.xml
    
    1
  
  
    scrumit
    /app/*

app-config.xml

And this is what I have when I start the server:

INFO : org.springframework.web.servlet.mvc.annotation.DefaultAnnotationHandlerMapping - Mapped URL path [/userstory/{projectid}/{sprintid}/] onto handler 'userstoryController'

The error is:

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.web.servlet.mvc.annotation.DefaultAnnotationHandlerMapping#0': Initialization of bean failed; nested exception is java.lang.IllegalStateException: Cannot map handler 'manageUserstoryController' to URL path [/userstory/{projectid}/{sprintid}/]: There is already handler of type [class ch.bsgroup.scrumit.controller.UserstoryController] mapped.

The program does not allow me to map UserstoryController to manageUserstoryController because of the existence of userstoryController.

Could anyone explain to me why userstoryController is generated, and how to map it properly. Thanks in advance.

Sotirios Delimanolis · Accepted Answer

The issue is the following. This element

already creates an instance of your UserstoryController controller because of @Controller. And then the elements in beans.xml creates another one.

When you annotate a class with @Controller and have an appropriate component-scan, you should not declare a separate bean element in your context.

The fact is, all of this

can be replaced with appropriate @Autowired annotations on fields. You don't even need getters and setters. For example

@Controller
@RequestMapping(value="userstory/{projectid}/{sprintid}/")
@SessionAttributes(value = "user")
public class UserstoryController {
    @Autowired
    private ISprintService sprintService;

    @Autowired
    private IUserStoryService userStoryService;

    @Autowired
    private IProjectService projectService;

    @Autowired
    private IBurnDownChartService burnDownChartService;

    @Autowired
    private ITaskService taskService;

    @RequestMapping(method=RequestMethod.GET)
    public String getUserstoryPage(@PathVariable("projectid") int pid, @PathVariable("sprintid") int sid,  @ModelAttribute("user") SerializablePerson user) {
        if (user.getId() != 0) {
            Project p = this.projectService.findProjectById(pid);
            if (p == null) {
                throw new ResourceNotFoundException(pid);
            }
            if (user.getRole().equals("User")) {
                return "userstory/user_userstory";
            }
            else {
                return "userstory/admin_userstory";
            }
        }
        return "redirect:../../../login";
    }
}

Here's some related documentation:

Spring mvc controller bean configuration

Answers (1)

Related Questions