CODEWITHSUNDEEP
javascript
Jonas Grumann
Jonas Grumann

Reputation: 10786

Uncaught TypeError: Type error when calling push()

I'm trying to simulate smoke on canvas. I want to create a new smoke puff and push it in the puffs array but I keep getting the "Uncaught TypeError: Type error" error.
Anyone know what I'm missing?

var puffs = [];

this.tick = function() {
    var puffLength = puffs.length;
    if ( addPuffs && ( puffLength < maxParticles )) {
        puffs.push({ //THIS ONE IT WHAT GIVES ME THE ERROR
            posX: oPoint.x,
            posY: oPoint.y,
            scale: .1,
            age: 0
        });
    }

    for(var i = 0; i < puffLength; i++) {

        var currentPuff = puffs[i];

        if(currentPuff.age == maxLife) {
            puffs.splice(i, 1);
        } else {
            currentPuff.posX += windX,
            currentPuff.posY += windY,
            currentPuff.scale += growingSpeed,
            currentPuff.age++;
        }

    }

    this.render();

}

Upvotes: 1

Views: 92

Answers (1)

Kevin Bowersox
Kevin Bowersox

Reputation: 94479

In the provided fiddle, addPuffs is not defined. You need to define this variable according to your business logic. Also oPoint.x and oPoint.y are not defined, these must also be initialized according to your business logic.

var oPoint = {x:1, y:2}; //declare according to logic
var addPuffs = true; //some logic here
if ( addPuffs && ( puffLength < maxParticles )) {
    puffs.push({ //THIS ONE IT WHAT GIVES ME THE ERROR
        posX: oPoint.x,
        posY: oPoint.y,
        scale: .1,
        age: 0
    });
}

Also when using drawImage() on canvas I believe the first argument must be a DOM element and not a path to the image.

Try:

  var img = new Image();
  img.src = "/static/img/particle.png";
  //Omitted code
  ctx.drawImage(img,80,80,1,1);

Upvotes: 1

Related Questions