CODEWITHSUNDEEP
javastack-overflowmergesort
Joseph Szymborski
Joseph Szymborski

Reputation: 1283

MergeSort Implementation gives StackOverflow

I've been trying to implement a MergeSort that splits the array into three sections instead of two. I seem to be getting a StackOverflow exception somewhere. Can someone help me find it? (The SOs are being reported on Lines 54,58,59)

import java.util.; import java.io.;

class MergeSortQuestion {

// merges sorted subarrays A[start...firstThird], A[firstThird+1,secondThird], and A[secondThird+1,stop]
public static void mergeThreeWay(int A[], int start, int firstThird, int secondThird, int stop) 
{

    int indexLeft = start;
    int indexFirstThird = firstThird+1;
    int indexSecondThird = secondThird+1;
    int tmp1[] = new int[A.length];
    int tmpIndex = start;
    while(tmpIndex <= firstThird){

        if (indexFirstThird < firstThird || (indexLeft <= firstThird && A[indexLeft] <= A[indexFirstThird])){

            tmp1[tmpIndex] = A[indexLeft];
            indexLeft++;

        }else if(indexSecondThird < secondThird || (indexFirstThird <= secondThird && A[firstThird] <= A[indexSecondThird])){

            tmp1[tmpIndex] = A[indexFirstThird];
            indexFirstThird++;

        }else{

            tmp1[tmpIndex] = A[indexSecondThird];
            indexSecondThird = indexSecondThird + 1;

        }

        tmpIndex++;
    }

    int i = 0;

    for(int temp : tmp1){
        A[i] = temp;
        i++;
    }



}



// sorts A[start...stop]
public static void mergeSortThreeWay(int A[], int start, int stop) {

    if (start < stop){

        int firstThird = (start+stop)/3;
        int secondThird = 2*(firstThird);
        mergeSortThreeWay(A, start, firstThird);
        mergeSortThreeWay(A, firstThird+1, secondThird);
        mergeSortThreeWay(A, secondThird+1, stop);
        mergeThreeWay(A, start, firstThird, secondThird, stop);
    }


}


public static void main (String args[]) throws Exception {

int myArray[] = {8,3,5,7,9,2,3,5,5,6}; 

mergeSortThreeWay(myArray,0,myArray.length-1);

System.out.println("Sorted array is:\n");
for (int i=0;i<myArray.length;i++) {
    System.out.println(myArray[i]+" ");
}
}

}

Upvotes: 0

Views: 84

Answers (1)

aUserHimself
aUserHimself

Reputation: 1597

Your firstThird and secondThird variables don't change value from one iteration to another at a certain point in the mergeSortThreeWay execution. On your example, I got:

start=4 stop=6
firstThird=3 secondThird=6
start=4 stop=6
firstThird=3 secondThird=6
// so java.lang.StackOverflowError

The formulas for computing firstThird and secondThird don't seem to work. Try using

firstThird = (stop-start)/3 + start;
secondThird = 2*(stop-start)/3 + start;

Upvotes: 1

Related Questions