CODEWITHSUNDEEP
schemeracket
nan
nan

Reputation: 57

Function in Scheme that checks whether the length of a list is even

Hi I have edited the code for function in scheme that checks whether the length of a list is even.

(define even-length?
  (lambda (l)
  (cond 
   ((null? l)#f)
   ((equal? (remainder (length(l)) 2) 0) #t)
   (else #f))))

Is it corrrect?

Upvotes: 0

Views: 2306

Answers (3)

Federico klez Culloca
Federico klez Culloca

Reputation: 27119

(define even-length? (lambda (l)
    (even? (length l))))

Usage:

(even-length? '(1 2 3 4))
#t
(even-length? '(1 2 3 ))
#f

As others pointed out, there is indeed a predicate to check evenness of a number, so why not using it?

EDIT: I just saw Jerry Coffin wrote the same function witht the same example... Sorry for repeating :-)

Upvotes: 1

Jerry Coffin
Jerry Coffin

Reputation: 490148

The code is clearly wrong -- your %2 assuming infix notation, where Scheme uses prefix notation. The syntax of your if is wrong as well -- for an if, the else is implicit (i.e. you have if condition true-expression false-expression. In this case, you're trying to return #t from one leg and #f from another leg -- that's quite unnecessary. You can just return the expression that you tested in the if.

Edit: one other detail -- you should really rename this to something like even-length?. Even if I assume that it's a predicate, a name like even would imply to me that (even 3) should return #f, and (even 4) should return #t -- but in this case, neither works at all.

Edit2: Since mquander already gave you one version of the code, I guess one more won't hurt. I'd write it like:

(define (even-length? L) (even? (length L)))

I don't like using lower-case 'l' (but itself) much, so I've capitalized it. Since even? is built in, I've used that instead of finding the remainder.

Running this produces:

> (even-length? `(1 2 3))
#f
> (even-length? `(1 2 3 4))
#t
>

This is different from what you had in one respect: the length of an empty list is 0, which is considered an even number, so:

(even-length? `())

gives #t.

Upvotes: 2

mqp
mqp

Reputation: 71945

You seem to have the syntax for if and cond all mixed up. I suggest referring to the language reference. if only has two clauses, and you don't write else for the else clause. (Hint: You shouldn't need an if for this function at all.)

Also, consider whether it makes sense to return null if the list is null; probably you want to return #t or #f instead.

Oh yeah, and rewrite your call of length to be a proper prefix-style Scheme function call.

Upvotes: 2

Related Questions