CODEWITHSUNDEEP
javascriptnode.jsexpresspug
bsr
bsr

Reputation: 58662

Jade : New warning on multiple attributes

I have updated jade to latest version, and started seeing this message in console

You should not have jade tags with multiple attributes

It is mentioned as feature, here 

0.33.0 / 2013-07-12
Hugely more powerful error reporting (especially with compileDebug set explicitly to true)
Add a warning for tags with multiple attributes

and I see it in the code. https://github.com/visionmedia/jade/blob/a38aa552f6f53554ac5605299b6b8c7e07cbdf1f/lib/parser.js#L662

But, what does it really signify. When will I get this warning. For example, when will I get error based on the below code (It works without warning, but to like to know when will I get error so that I can compare with my code)

mixin link(href, name)
    a(class=attributes.class, href=href)= name
    a(href=href, attributes)= name

    +link('/foo', 'foo')(class="btn")

Upvotes: 17

Views: 4563

Answers (2)

Andreas Covidiot
Andreas Covidiot

Reputation: 4755

(I found this question through googleing this warning as one of the first results because I wanted to get rid of it ...)

The accepted answer above did not help me in the following case, but it shows how one can get rid of the warning without loosing the attributes functionality (it does not provide an answer to why it works this way):

// using mixins similar to +link(param1,param2) above where 'data' and 'class' 
// below are not named mixin params

// OK (without a warning):
+link("foo", data="true")(class="bar")

// WARNING is shown:
+link("foo")(class="bar")(data="true")

// ERROR on compiling:
+link("foo", class="bar", data="true")

(I'm sorry to create so much misunderstandings as shown in the comments below and hope my last edit here clarifies it to be a valid, although slightly more general, answer/help for those docpad warnings)

Upvotes: 0

Prinzhorn
Prinzhorn

Reputation: 22508

Multiple "attributes" doesn't mean what you probably think it means. It's not an HTML attribute as we know it, but a token of type "attribute".

Example:

a(href="#WAT").some-class(title="WAT")

Note how I have two attribute sections, each with one attribute.

Better put them in one attribute section:

a(href="#WAT", title="WAT").some-class

Upvotes: 25

Related Questions