Disable Submit Button during Postback

Question

I'm trying to disable the button during form submission but not able to do so. Here is the javascript code

<script type="text/javascript">
function Validate(b)
{
function stuff()
{
var temp = document.getElementById("<%=txt_stuff.ClientID %>").value;
var val = /^[a-zA-Z0-9 ]+$/
if(temp=="")
{
alert("Please Enter Stuff");
return false;
}
else if(val.test(temp))
{
return true;
}
else
{
alert("Name accepts only spaces and charcters");
return false;
}
}
function price()
{
var temp2 = document.getElementById("<%=txt_price.ClientID %>").value;
var val2 = /^[0-9 ]+$/
if(temp2=="")
    {
    alert("Please Enter Price");
    return false;
    }
else if(val2.test(temp2))
    {
    return true;
    }
else
    {
    alert("Price accepts only Number");
    return false;
    }
}
if(stuff() && price())
{
b.disabled = true;
b.value = 'Submitting...';
return true;
}
else
{
return false;
}
}

</script>
Here is the button code



 <asp:Button ID="Button2" runat="server" Text="Add Record" OnClientClick = "return Validate(this)" 
         onclick="Button2_Click" />

The button gets disabled but the value isn't submitted into the database.

Database update code is

 protected void Button2_Click(object sender, EventArgs e)
        {
            System.Threading.Thread.Sleep(500);
            SqlConnection con = new SqlConnection();
            con.ConnectionString = "Data Source=DTPXP-77A;Initial Catalog=practice;Integrated Security=true";
            con.Open();
            SqlCommand cmd = new SqlCommand("insert into expense values(@person,@item,@expdate,@price)", con);
            cmd.Parameters.Add("@person", SqlDbType.VarChar);
            cmd.Parameters.Add("@item", SqlDbType.VarChar);
            cmd.Parameters.Add("@expdate", SqlDbType.DateTime);
            cmd.Parameters.Add("@price", SqlDbType.Int);
            cmd.Parameters["@person"].Value = droplist_person.SelectedItem.ToString();
            cmd.Parameters["@item"].Value = txt_stuff.Text;
            cmd.Parameters["@expdate"].Value = DateTime.Now.ToString();
            cmd.Parameters["@price"].Value = txt_price.Text;
            cmd.ExecuteNonQuery();
            InsertHistory();
            Response.Redirect("Add.aspx");

        }

Answer 1

I think it's the way you are inserting the items into the database since you said that it disables the button but doesn't insert the database. So to me, that means the event is firing but something is wrong with the way you are inserting. This is how my buttons look, using your code..

protected void Button2_Click(object sender, EventArgs e)
    {
        string person = droplist_person.SelectedItem.Text;
        string item = txt_stuff.Text;
        string expdate = DateTime.Now.ToString();
        string price = txt_price.Text;

        System.Threading.Thread.Sleep(500);
        SqlConnection con = new SqlConnection("Data Source=DTPXP-77A;Initial Catalog=practice;Integrated Security=true");
        con.Open();
        SqlCommand cmd = new SqlCommand("INSERT INTO (expense person, item, expdate, price) VALUES (@person, @item, @expdate, @price)", con);
        cmd.Parameters.AddWithValue("@person", person);
        cmd.Parameters.AddWithValue("@item", item);
        cmd.Parameters.AddWithValue("@expdate", expdate);
        cmd.Parameters.AddWithValue("@price", price);
        cmd.ExecuteNonQuery();
        InsertHistory();
        Response.Redirect("Add.aspx");

        Button2.Enabled = false; //you can disable the button one the button click as well. 

        Page.ClientScript.RegisterStartupScript(this.GetType(), "Call my function", "mess();", true);

        }

I would also surround that in a try/catch. Also, as far as I know, the Add is the "old" way of inserting items into the database. AddWithValue is going to be the best way since you are inserting items from drop downs and from text boxes. I think this is the where the problem lies. You can also put the connection inside the connection inside the SqlConnection like above to "clean" things up a bit. As to your "2nd" question, I'm not completely sure what you mean, but I hope this solves the problem to your 1st question.

EDIT: Added the disabling of the button since it was described in the title.

EDIT 2: Also, remove the UseSubmitBehavior="false" and the OnClientClick. Instead, you can call the message in the behind code.. Look above for example.

EDIT 3: From what I understand then, you will want to keep what the code the inserts the values. So keep the OnClientClick = "return Validate();" And then in your button click, disable the button. Then you will want to add if(!PostBack) to the page load, like so.. This will enable the button on the page load if the postback has happened. So what will be happening is that you disable the button, then once it posts back, it will be re-enabled.

protected void Page_Load(object sender, EventArgs e)
{
    if(!IsPostBack)
     {
       Button2.Enabled = true;
     }
}

Answer 2

remove the UseSubmitBehavior="false" attribute? and you dont need to return anithing in the javascript (return false is used to cancel a postback)