CODEWITHSUNDEEP
javaswingjlist
Eric Lang
Eric Lang

Reputation: 274

Populating JList with List<String> nullpointerexception

I am trying to populate the JList using a file I create, before I write the code for adding things to the file that is being read, I would like to make sure it will be read, and display properly on the screen. I am getting a nullpointerexception, and my GUI is launching, but only the "enter" button is showing. I appreciate any help anyone can offer me with this issue.

package movieinfo;

import java.awt.Color;
import java.awt.GridBagConstraints;
import java.awt.GridBagLayout;
import java.awt.List;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.io.File;
import java.io.IOException;
import java.nio.charset.Charset;
import java.util.ArrayList;
import java.util.Map;
import javax.swing.BorderFactory;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JList;
import javax.swing.JScrollPane;
import javax.swing.JTextArea;
import javax.swing.JTextField;

import org.apache.commons.io.FileUtils;

import com.json.parsers.JSONParser;
import com.json.parsers.JsonParserFactory;


public class Swinggui {
    private static JButton enter;
    private static JTextField movietext;
    private static JTextArea movieinfo;
    private static JList listofmovies;//converts moviestowatch into gui element.
    private static File textfilemovie; //file which movies marked for watching are saved
    private static java.util.List<String> moviestowatch; //arraylist which is populated by textfilemovie than printed to GUI element.
    public static void main(String[] args) throws IOException
    {
        Gui();
        Json();
        YourMovies();
    }
    public static void Gui()
    {
        JFrame maingui = new JFrame("Gui");
        maingui.setLayout(new GridBagLayout());
        GridBagConstraints c = new GridBagConstraints();
        c.fill = GridBagConstraints.VERTICAL;
        enter = new JButton("Enter");
        c.gridx = 2;
        c.gridy = 1;
        maingui.add(enter, c);
        movieinfo = new JTextArea(5,20);
        movieinfo.setBorder(BorderFactory.createMatteBorder(2,2,2,2,Color.red));
        movietext = new JTextField(18);
        c.gridx = 1;
        c.gridy = 1;
        maingui.add(movietext, c);
        final JScrollPane scrolll = new JScrollPane(movieinfo);
        c.gridx = 1;
        c.gridy = 4;
        c.gridwidth = 2;
        maingui.add(scrolll, c);
        final JLabel titlee = new JLabel("Enter movie name below!");
        c.gridx = 1;
        c.gridy = 0;
        maingui.add(titlee, c);
        maingui.setResizable(false);
        maingui.setVisible(true);
        listofmovies = new JList(moviestowatch.toArray());
        c.gridx = 2;
        c.gridy = 3;
        maingui.add(new JScrollPane(listofmovies), c);
        movieinfo.setLineWrap(true);
        movieinfo.setWrapStyleWord(true);
        movieinfo.setEditable(false);
        scrolll.getPreferredSize();
        //pangui.setPreferredSize(new Dimension(300, 150));
        //pangui.add(scrolll, BorderLayout.CENTER);
        //movieinfo.add(scrolll);
        maingui.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        maingui.pack();

    }
    public static void Json()
    {
        enter.addActionListener(new ActionListener(){
            @SuppressWarnings("rawtypes")
            public void actionPerformed(ActionEvent e)  
            {
                System.out.println(apicall.getMovieInfo(movietext.getText()));
                JsonParserFactory factory=JsonParserFactory.getInstance();
                JSONParser parser=factory.newJsonParser();
                Map jsonData=parser.parseJson(apicall.getMovieInfo(movietext.getText()));
                String Title = (String)jsonData.get("Title");
                String Year = (String)jsonData.get("Year");
                String Plot = (String)jsonData.get("Plot");
                movieinfo.setText("Title: "+Title+"\nYear: "+ Year +"\nPlot: "+Plot);
            }
        });
    }
    public static void YourMovies() throws IOException
    {
        textfilemovie = new File("yourmovies.txt");
        moviestowatch = FileUtils.readLines(textfilemovie);

    }
}

Upvotes: 0

Views: 907

Answers (3)

Reimeus
Reimeus

Reputation: 159844

moviestowatch is not assigned when Gui is called - reverse the order of these methods

YourMovies();
Gui();

and follow Java naming conventions for method names with initial lowercase latter, e.g. loadMovies

Upvotes: 1

musical_coder
musical_coder

Reputation: 3896

You're calling moviestowatch.toArray() before you instantiate moviestowatch. You need to call YourMovies() before you call Gui().

Upvotes: 2

sanbhat
sanbhat

Reputation: 17622

I see that in the method Gui() you are using an un-initialized list. The method where the list is getting initialized is called afterwards ( method YourMovies())

listofmovies = new JList(moviestowatch.toArray());
                         ^^^^^^^^^^^^^
                         this is null

On a side note:

As per Java naming convention, methods start with small case and follow camel case, example - yourMovies() gui()

Upvotes: 2

Related Questions