Why is this code not working? Hangman

Question

I am creating a hangman game. Everything works fine, I have code ready to be used for failing the game and giving -1 to the guesses. Though when adding it to the else statement it gets duplicate equal to the length of the word and it also gives a guess—even though its right? I don't see what's wrong in the code? I believe it's my code when guessing wrong which is not placed right though I see no other way?

This is the code:

private class check implements ActionListener {
   public void actionPerformed(ActionEvent ae) {
      try {
         // Grabs the letter from the guessField and converts it into a char
         // which can be used to compare against the word.
         guess = guessField.getText();
         guessField.setText("");
         char guess2 = guess.charAt(0);

         // --------------------
         // Here is the guessing logic but it's currently
         // not working and you can not win since i haven't written code for
         // it yet. it's not selecting all the letters. for Example if
         // choosing A in a word such as Banana it only selects the first
         // a--------------------------- //
         String displaySecret = wordField.getText();
         if (displaySecret.equals("")) {/* case for fist execution */
            displaySecret = "";
            for (int i = 0; i < random.length(); i++)
               displaySecret += "_ ";
         }
         String newDisplaySecret = "";
         for (int v = 0; v < random.length(); v++) {
            if (guess2 == random.charAt(v)) {
               newDisplaySecret += random.charAt(v); // newly guessed
                                                     // character
            } else {
               newDisplaySecret += displaySecret.charAt(v); // old state
               guesses--;
               statusLabel.setText("Guesses left: " + guesses);
               missField.setText(missField.getText() + guess);
               if (guesses <= 0) {
                  JOptionPane.showMessageDialog(null,
                        "Game over! The word was: " + random);
                  guessField.setEditable(false);
                  wordField.setText("");
                  missField.setText("");
                  guesses = 7;
                  statusLabel.setText("Guesses left: " + guesses);
               }
            }
         }
         displaySecret = new String(newDisplaySecret);
         wordField.setText(displaySecret);
         if (displaySecret.equals(random)) {
            JOptionPane.showMessageDialog(null, "You Won! The Word was: "
                 + random);
            guesses = 7;
            statusLabel.setText("Guesses left: " + guesses);
            wordField.setText("");
            missField.setText("");
            guessField.setEditable(false);
         }
      } catch (Exception e) {
         System.out.println(e);
      }
   }
}

Answer 1

Here is what you need to check your word and generate "newDisplaySecret":

for (int v = 0; v < random.length(); v++) {
      if (guess2 == random.charAt(v)) {
           newDisplaySecret += random.charAt(v); // newly guessed
                                                 // character
        } else {
           newDisplaySecret += displaySecret.charAt(v);
}

Here is how you can determine whether the player guessed right or wrong:

if(newDisplaySecret.equals(displaySecret)){
    guesses --;

}

This needs to be placed after your check word code. Your code seems to decrement guesses for each letter in the word random.

Update display:

     displaySecret = new String(newDisplaySecret);
     wordField.setText(displaySecret);

Now that you know what the current state of affairs is for this move you can decide if the person has won or lost or just needs to continue playing:

if(guesses <= 0){
    /*place here instructions for loosing scenario*/
}else{
     if(displaySecret.equals(random)) {
         /*place here instructions for winning scenario*/
     }
    /*simply do nothing the game is neither lost or won*/
}

Hope this helps

Answer 2

If randomis your Word, you iterate over each Character of it and then check whether each single character matches the guess you get for each character that doesn't match the guess a -1.

For Example: The Word is Bananaramaand you guess a nyour first and second matches will go to the else clause. then one time the if clause goes again, then the else and so on.

You have to

1. iterate over all characters, check whether they match or not
2. if a match occurs, replace the char and increase the counter
3. check if the counter of correct characters equals 0
4. if so, decrease the guesses

Some other tips: you should use .toLower() on your input and word string before comparsion to allow insensitivity for case

Some sample code:

int charsGuessedCorrectly;
for ( int i = 0; i < random.length( ); i++ )
{
    if ( random.charAt( i ) == guess )
    {
        charsGuessedCorrectly++;
        newDisplaySecret += random.charAt(v); // newly guessed
                                              // character
    }
}

if ( charsGuessedCorrectly == 0 )
{
    newDisplaySecret += displaySecret.charAt(v); // old state
    guesses--;
    statusLabel.setText("Guesses left: " + guesses);
    missField.setText(missField.getText() + guess);
    if (guesses <= 0) {
       JOptionPane.showMessageDialog(null,
           "Game over! The word was: " + random);
       guessField.setEditable(false);
       wordField.setText("");
       missField.setText("");
       guesses = 7;
       statusLabel.setText("Guesses left: " + guesses);
}