liewl
liewl

Reputation: 4071

Inserting data in XML file with PHP DOM

I was trying to insert new data into an existing XML file, but it's not working. Here's my xml file:

<list>
    <activity>swimming</activity>
    <activity>running</activity>
<list>

Now, my idea was making two files: an index page, where it displays what's on the file and provides a field for inserting new elements, and a php page which will insert the data into the XML file. Here's the code for index.php:

<html>
<head><title>test</title></head>
</head>

<?php
    $xmldoc = new DOMDocument();
    $xmldoc->load('sample.xml', LIBXML_NOBLANKS);

    $activities = = $xmldoc->firstChild->firstChild;
    if($activities!=null){
        while(activities!=null){
            echo $activities->textContent.'<br/>';
            activities = activities->nextSibling.
        }
    }
?>

<form name='input' action='insert.php' method='post'>
    insert activity:
    <input type='text' name='activity'/>
    <input type='submit' value='send'/>
</form>
</body>
</html

and here's the code for insert.php:

<?php
    header('Location:index.php');
    $xmldoc = new DOMDocument();
    $xmldoc->load('sample.xml');

    $newAct = $_POST['activity'];

    $root = $xmldoc->firstChild;

    $newElement = $xmldoc->createElement('activity');
    $root->appendChild($newElement);
    $newText = $xmldoc->createTextNode($newAct);
    $newElement->appendChild($newText);

    $xmldoc->save('sample.xml');
?>

The user is to access index.php, where he would see a list of the current activities present in the XML file, and a text field below where he can insert new activities. Upon clicking the send button, the page would call insert.php, which contains a code that opens the XML file in a DOM tree, inserts a new node under the root node and calls back the index.php page, where the user should be able to see the list of activities, his new activity there under the others. It is not working. When i click on the button to submit a new entry, the pages refreshes and apparently nothing happens, the XML is the same as before. What did i do wrong? Also, i'd like to know if there's a better way of doing it.

Upvotes: 6

Views: 36375

Answers (6)

Crystal Eye
Crystal Eye

Reputation:

I think I know what is the problem with your code. You should not write like that: <?xml-stylesheet type="text/xsl" href="sample.xsl" ?> The right code is:

<?xml:stylesheet type="text/xsl" href="sample.xsl" ?>

Upvotes: 1

wicho
wicho

Reputation: 21

this is the code i work for me.

index.php

<html>
<head><title>test</title></head>
</head>

<?php
    $xmldoc = new DOMDocument();
    $xmldoc->load('sample.xml', LIBXML_NOBLANKS);

    $activities = $xmldoc->firstChild->firstChild;
    if($activities!=null){
        while($activities!=null){
            echo $activities->textContent.'<br/>';
            $activities = $activities->nextSibling;
        }
    }
?>

<form name='input' action='insert.php' method='post'>
    insert activity:
    <input type='text' name='activity'/>
    <input type='submit' value='send'/>
</form>
</body>
</html>




insert.php


<?php
    header('Location:index.php');
    $xmldoc = new DOMDocument();
    $xmldoc->load('sample.xml');

    $newAct = $_POST['activity'];

    $root = $xmldoc->firstChild;

    $newElement = $xmldoc->createElement('activity');
    $root->appendChild($newElement);
    $newText = $xmldoc->createTextNode($newAct);
    $newElement->appendChild($newText);

    $xmldoc->save('sample.xml');
?>

sample.xml

<list>
  <activity>swimming</activity> 
  <activity>running</activity> 
</list>

Upvotes: 2

Amdad Hossain
Amdad Hossain

Reputation: 51

Final Solution

sample.XML

<list>
    <activity>swimming</activity>
    <activity>running</activity>
    <activity>Jogging</activity>
    <activity>Theatre</activity>
    <activity>Programming</activity>
</list>

index.php

<html>
<head><title>test</title></head>
</head>

<?php
    $xmldoc = new DOMDocument();
    $xmldoc->load("sample.xml", LIBXML_NOBLANKS);

    $activities = $xmldoc->firstChild->firstChild;
    if($activities!=null){
        while($activities!=null){
            echo $activities->textContent."<br/>";
            $activities = $activities->nextSibling;
        }
    }
?>

<form name="input" action="insert.php" method="post">
    insert activity:
    <input type="text" name="activity"/>
    <input type="submit" value="send"/>
</form>
</body>
</html>

insert.php

<?php
    header('Location:index.php');
    $xmldoc = new DOMDocument();
    $xmldoc->load('sample.xml');

    $newAct = $_POST['activity'];

    $root = $xmldoc->firstChild;

    $newElement = $xmldoc->createElement('activity');
    $root->appendChild($newElement);
    $newText = $xmldoc->createTextNode($newAct);
    $newElement->appendChild($newText);

    $xmldoc->save('sample.xml');
?>

Upvotes: 5

Manita
Manita

Reputation:

Actually you made mistakes in two places.

This line should be I think because of the typo, you missed an equal sign. Also

These lines should be

Try now, it should work, Hop this would make some sense

Upvotes: 2

Mohanpal
Mohanpal

Reputation:

$newText = $xmldoc->createTextNode($newActv);

Change this line to

$newText = $xmldoc->createTextNode($newAct);

Upvotes: 2

Owen
Owen

Reputation: 84503

is your code block copy and pasted from your existing files? if so i see two potential issues:

<form name='input' action'insert.php' method='post'> // should be:
<form name="input" action="insert.php" method="post">

note: you're missing action="insert.php", which would cause the form to just reload itself without submitting, which is the behaviour you describe.

secondly, make sure you have write permission to "sample.xml". you can confirm if you're actually writing anything:

print 'I wrote '.$xmldoc->save('sample.xml').' bytes of data';

Upvotes: 8

Related Questions