CODEWITHSUNDEEP
c#if-statementswitch-statement
user2911044
user2911044

Reputation: 127

Possible to use && or || in switch statement? Visual C#

So I was making a Rock Paper Scissor game and I've sort of made adjustments to it to include life and other things. Now I got stuck with the switch statement. My if statement works fine:

private void Result_TextChanged(object sender, EventArgs e)
{
     if (playerscore == 1 || pcscore == 1)
     {
          PlayerLife.Image = Properties.Resources.Five;
     }
}

I was wondering how I could translate this to the switch statement? 

private void Result_TextChanged(object sender, EventArgs e)
{              
    switch (playerscore || pcscore)
    {
         case 1:
             PlayerLife.Image = Properties.Resources.Five;
             break;
    }
}

Doesn't seem to work.

Upvotes: 9

Views: 23066

Answers (7)

Harrison
Harrison

Reputation: 3963

You could write it like this but why would you want to?

  switch (playerscore == 1 || pcscore == 1)
        {
            case true:
                PlayerLife.Image = Properties.Resources.Five;
                break;
            default:
                break;
        }

As Jeppe points out in the comment below, when you use || or && you end up with a bool and an if statement should be used.

Here is a great answer by @EricLippert on what can be used as the expression in a swtich statement.

Upvotes: 3

Federico
Federico

Reputation: 479

Suppose that playerscore and pcscore are integer who has 0 or 1 as possible values

    resp = playerscore + 10 * pcscore;
    switch (resp)
    {
        case 0:
            // both are false
            break;
        case 1:
            // playerscore true
            break;
        case 10:
            // pcscore true
            break;
        case 11:
            // both are true
            break;
        default:
            // error in input data
            break;
    }

Upvotes: 0

Servy
Servy

Reputation: 203842

If you have a whole bunch of variables, say not just two, but 5, 10, or even an unknown number, then what you can do is put all of the values that you want to compare to 1 into a collection and then act on that collection as a whole.

//this could just be a list/array accepted as a paramter, 
//can include other variables, or whatever
var scores = new []{playerscore, pcscore};

if(scores.Any(score => score == 1))
    PlayerLife.Image = Properties.Resources.Five;

switch isn't really an appropriate tool for manipulating collections like this.

Upvotes: 1

Rahul Tripathi
Rahul Tripathi

Reputation: 172458

The simple answer is No. You cant use it like that.

Switch works with single expression.

You may check MSDN for details.

You may try like this:-

  if (playerscore == pcscore)
        {
            switch (playerscore)
            {
                case 1:
                PlayerLife.Image = Properties.Resources.Five;
                break;
            }
        }

EDIT:-

As commented by Jeppe Stig Nielsen in the comments, You can switch on any expression of a suitable type. That expression may contain ||. There can be many case labels associated with each switch section in a switch block.

But personally speaking that would not be a good practice to follow. You may try to use if statement for that.

You may try like this if you want:

 switch (playerscore == 1 || pcscore == 1)

Upvotes: 11

Mike Christensen
Mike Christensen

Reputation: 91628

In C#, a switch statement resolves a single expression and compares that value with a list of possible cases:

switch(someExpression)
{
   case x: // This runs if someExpression == x
      break;
   case y: // This runs if someExpression == y
      break;
}

Now, you could switch on the expression (playerscore == 1 || pcscore == 1) like so:

switch(playerscore == 1 || pcscore == 1) // This expression is either true or false
{
   case true: // Runs if playerscore is 1 or pcscore is 1
      break;
   case false: // runs if neither playscore or pcscore are 1
      break;
}

However, the above is rather unreadable and silly. You'd be best off with the if statement:

if(playerscore == 1 || pcscore == 1)
{
   // Runs if playerscore is 1 or pcscore is 1
}
else
{
   // runs if neither playscore or pcscore are 1
}

Upvotes: 3

rudy
rudy

Reputation: 191

This makes no sense: in a switch statement you always want to compare with a specific type, rather than to a boolean value as follows:

switch (playerscore || pcscore)

in your case use the 'if'-statement

Upvotes: 0

Jonathan
Jonathan

Reputation: 21

What you are trying to do doesn't make sense, if playerscore = 3 and pcscore = 2 then what would playerscore || pcscore be equal to?

Upvotes: 1

Related Questions