CODEWITHSUNDEEP
php
Frantumn
Frantumn

Reputation: 1774

Read file names from directory

I am trying to read and display all the files in a directory using this code. It works fine for files in the same directory as the script. But when I try to display files in a folder (files/) it is giving me problems.

I've tried setting the directoy variable to many different things. like...
files/
files
/files/
etc... nothing seems to work. Does anyone have any idea why?

<?php
$dhandleFiles = opendir('files/');
$files = array();

if ($dhandleFiles) {
    while (false !== ($fname = readdir($dhandleFiles))) {
        if (is_file($fname) && ($fname != 'list.php') && ($fname != 'error.php') && ($fname != 'index.php')) {
            $files[] = (is_dir("./$fname")) ? "{$fname}" : $fname;
        }
    }
    closedir($dhandleFiles);
}

echo "Files";
echo "<ul>";
foreach ($files as $fname) {
    echo "<li><a href='{$fname}'>{$fname}</a></li>";
}
echo "</ul>";
?>

Upvotes: 0

Views: 160

Answers (4)

sparky
sparky

Reputation: 11

This reads and prints filenames from a sub-directory:

$d = dir("myfiles");
while (false !== ($entry = $d->read())) {
  if ($entry != ".") {
    if ($entry != "..") {
        print"$entry";       
    }
  }
}
$d->close();

Upvotes: 1

Anthony Sterling
Anthony Sterling

Reputation: 2441

This should help - take a look at SplFileInfo too.

<?php
class ExcludedFilesFilter extends FilterIterator {
    protected
        $excluded = array(
            'list.php',
            'error.php',
            'index.php',
        );
    public function accept() {
        $isFile     = $this->current()->isFile();
        $isExcluded = in_array($this->current(), $this->excluded);

        return $isFile && ! $isExcluded;
    }
}

$dir = new DirectoryIterator(realpath('.'));

foreach (new ExcludedFilesFilter($dir) as $file) {
    printf("%s\n", $file->getRealpath());
}

Upvotes: 1

wpsidi
wpsidi

Reputation: 119

How about using glob function.

<?php
define('MYBASEPATH' , 'files/');
foreach (glob(MYBASEPATH . '*.php') as $fname) {
    if($fname != 'list.php' && $fname != 'error.php' && $fname != 'index.php') {
        $files[] = $fname;
    }
}
?>

read more about getting all files in directory here

Upvotes: 1

Marc B
Marc B

Reputation: 360882

You're not including the full path in your array:

while($fname = readdir($dhandleFiles)) {
    $files[] = 'files/' . $fname;
               ^^^^^^^^---must include actual path
}

Remember that readdir() returns ONLY the filename, without path information.

Upvotes: 2

Related Questions