user2928683
user2928683

Reputation: 1

What is causing my NullPointerException?

My program compiles perfectly, but whenever I try to run it throws a NullPointerException. I tried searching this up, and found that the error relates to some value being null while the program is trying to use it, but I re-checked everything and came up blank.

Here's the error:

java.lang.NullPointerException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) 
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) 
at java.lang.reflect.Method.invoke(Unknown Source) 
at edu.rice.cs.drjava.model.compiler.JavacCompiler.runCommand(JavacCompiler.java:27‌​2)

The code:

import javax.swing.*;
import java.util.Scanner;

public class WorldsMostBoringGame
{ 
  public void main (String [] args)
  {    
    System.out.println("You are in a room with a locked door and a key.");

     Scanner keyboard = new Scanner(System.in);
     boolean hasKey = false, doorOpen = false, amIDoneYet = false, monsterAlive = true;

    while (!amIDoneYet)
    {
      String userInput = keyboard.nextLine();

      if (userInput == "look around")
        LookAround(hasKey);
      else if (userInput == "get key")
        GetKey(hasKey, monsterAlive);
      else if (userInput == "open door")
        OpenDoor(doorOpen, hasKey, amIDoneYet);
      else if (userInput == "kill monster")
        KillMonster(monsterAlive);
      else
        System.out.println(userInput+ " is not a recognized command.");
    }
  }

  public boolean GetKey(boolean hasKey, boolean monsterAlive)
  {
    if (hasKey == false && monsterAlive == false)
      System.out.println("You pick up the key.");
    else if (hasKey == true && monsterAlive == false)
      System.out.println("You already picked up the key.");
    else if (monsterAlive == true)
    {
      System.out.println("You must kill the monster first.");
      return hasKey = false;
    }

    return hasKey = true;
  }

  public void LookAround(boolean hasKey)
  {
    if (!hasKey)
      System.out.println("You are in a room with a locked door and a key.");
    else
      System.out.println("You are in a room with a locked door. You have a key.");
  }

  public boolean OpenDoor(boolean doorOpen, boolean hasKey, boolean amIDoneYet)
  {
    if (hasKey)
    {
      System.out.println("You unlock the door. Game over. You win.");
      amIDoneYet = true;
      return doorOpen;
    }
    else
    {
      System.out.println("The door is locked. Find a key.");
      return doorOpen = false;
    }
  }

  public boolean KillMonster(boolean monsterAlive)
  {
    System.out.println("You kill the monster.");
    return monsterAlive = false;
  }
}

Upvotes: 0

Views: 13692

Answers (2)

Junjie
Junjie

Reputation: 1175

import javax.swing.*;
import java.util.Scanner;

public class WorldsMostBoringGame
{ 
  public static void  main(String [] args)
  {    
    System.out.println("You are in a room with a locked door and a key.");

     Scanner keyboard = new Scanner(System.in);
     boolean hasKey = false, doorOpen = false, amIDoneYet = false, monsterAlive = true;

    while (!amIDoneYet)
    {
      String userInput = keyboard.nextLine();

      if (userInput.equals("look around"))
        LookAround(hasKey);
      else if (userInput.equals("get key"))
        GetKey(hasKey, monsterAlive);
      else if (userInput.equals("open door"))
        OpenDoor(doorOpen, hasKey, amIDoneYet);
      else if (userInput.equals("kill monster"))
        KillMonster(monsterAlive);
      else
        System.out.println(userInput+ " is not a recognized command.");
    }
  }

  public static boolean GetKey(boolean hasKey, boolean monsterAlive)
  {
    if (hasKey == false && monsterAlive == false)
      System.out.println("You pick up the key.");
    else if (hasKey == true && monsterAlive == false)
      System.out.println("You already picked up the key.");
    else if (monsterAlive == true)
    {
      System.out.println("You must kill the monster first.");
      return hasKey = false;
    }

    return hasKey = true;
  }

  public static void LookAround(boolean hasKey)
  {
    if (!hasKey)
      System.out.println("You are in a room with a locked door and a key.");
    else
      System.out.println("You are in a room with a locked door. You have a key.");
  }

  public static boolean OpenDoor(boolean doorOpen, boolean hasKey, boolean amIDoneYet)
  {
    if (hasKey)
    {
      System.out.println("You unlock the door. Game over. You win.");
      amIDoneYet = true;
      return doorOpen;
    }
    else
    {
      System.out.println("The door is locked. Find a key.");
      return doorOpen = false;
    }
  }

  public static boolean KillMonster(boolean monsterAlive)
  {
    System.out.println("You kill the monster.");
    return monsterAlive = false;
  }
}

change all the method to static, and "==" should n't used to compare composed type

Upvotes: 0

Reimeus
Reimeus

Reputation: 159754

Add a static keyword to the main method so the application has a valid entry point

public static void main (String [] args) {

Edit:

Once this change is made create an instance of WorldsMostBoringGame such that the instance methods can be invoked:

WorldsMostBoringGame game = new WorldsMostBoringGame(); // create this instance
while (!amIDoneYet) {
   String userInput = keyboard.nextLine();
    if ("look around".equals(userInput)) { // use String.equals
       game.lookAround(hasKey);
    } ...

Upvotes: 15

Related Questions