CODEWITHSUNDEEP
javascriptarraysobject
softvar
softvar

Reputation: 18435

append values to array inside object based on key in JS

I have an object and want to append values to arrays inside it based on key.

For eg.

var A = {};
A[room1] = ["1"];
A[room2] = ["2"];
A[room3] = ["3"];

which will be looking like

A = {"room1":["1"], "room2":["2"], "room3":["3"]};

But what I want is that whenever a user gives some value corresponding to the already added key, instead of overwriting the previous value I want to append in it.

If, for example, value came as 101 and I want to add it to key room1 in such a way that later these values can be retrieved easily.

So the whole object this time becomes

A = {"room1":["1","101"], "room2":["2"], "room3":["3"]};

Now if I want to add 201 to key room2 , it will be:

A = {"room1":["1","101"], "room2":["2","201"], "room3":["3"]};

What I have I tried?

I have an array. I don't want to use many arrays.

var arr = [];

whenever value cam I push it to the array

arr.push(value);

But pushing it to the array leads to adding values to all not to the corresponding key

Upvotes: 0

Views: 7355

Answers (3)

Rajaprabhu Aravindasamy
Rajaprabhu Aravindasamy

Reputation: 67207

Your requirement can be achieved in this way too.

function pushValue(obj, key, value)
 {
     if(obj[key])
     {
       if(obj[key].push)
         {
            obj[key][obj[key].length] = value;
         }
       else
         {
            var xContainedVal = obj[key];
            obj[key] =[xContainedVal, value];
         }
     }
     else
     {
         alert("Key Not Found!");
     }
 }

Updated:

function pushValue(obj, key, value)
 {
     if(obj[key])
     {
        obj[key][obj[key].length] = value;
     }
     else
     {
        obj[key] =[value];
     }
 }

A working demo

Upvotes: 1

jfriend00
jfriend00

Reputation: 707218

[[The first part of this answer is based on a previous version of the OP's question which has now been edited to a different problem. See the second part of this answer for the solution which applies to the current edit of the question (It really messes things up when the whole question gets changed to something else.]]

Original Answer

You just have to test if the key already exists and examine if there's already an array there. If the key doesn't exist, add it. If the key exists and it's already an array, just push another value into the array. If the key exists, but it's not an array, grab the value and then reset the key to an array with the first two values in it.

Here's code to do that:

function addValue(obj, key, value) {
    if (obj.hasOwnProperty(key)) {
        // check if it's already an array using the recommended way of detecting an array
        if (Object.prototype.toString.call(obj[key]) === "[object Array]")
            obj[key].push(value);
        } else {
            var firstVal = obj[key];
            obj[key] = [firstVal, value];
        }
    } else {
        obj[key] = value;
    }
}

Latest Answer

FYI, your data structure choice is difficult to both read and write because both reader and writer have to check the type of a value before they can operate on it. It would be much easier if items were just always arrays with one or more elements in them like this.

// one item for each key
A = {"room1":["1"], "room2":["2"], "room3":["3"]};

// add 101 to room 1
A = {"room1":["1","101"], "room2:["2"], "room3":["3"]};

// add 201 to room 2
A = {"room1":["1","101"], "room2":["2","201"], "room3":["3"]};

Then, you would need any special code to read and to write, you'd just check if the key exists and if so, push a new value into it. If not, add the array.

In this case, adding a value would just be this

function addValue(obj, key, value) {
    if (obj.hasOwnProperty(key)) {
        obj[key].push(value);
    } else {
        obj[key] = [value];
    }
}

Upvotes: 4

Sohil Desai
Sohil Desai

Reputation: 2988

try this

 function pushValue(obj, key, value)
 {
      if(obj.hasOwnProperty(key) {
           var currentVal = obj[key];
           if(currentVal instanceof Array)
                obj[key].push(value);
           else
                obj[key] = [currentVal, value];
      } else {
           alert("No such key.");
      }
 }

Upvotes: 1

Related Questions