CODEWITHSUNDEEP
cprintf
Piers
Piers

Reputation: 773

Can the input and output strings to sprintf() be the same?

I have used this type of convention many times in my code in the past:

strcpy ( cTmpA, "hello" );
sprintf ( cTmpA, "%s world", cTmpA );

Recently I switched my legacy C compiler to Visual Studio 2005, and found I got a garbled string resulting from the above code. It then occurred to me that perhaps the behaviour of sprintf() is not rigidly defined where one of the inputs matches the output string.

Is the above code valid K&R C? If not, how do I find all the places in my code where this type of call to sprintf() has occurred?

Upvotes: 25

Views: 12828

Answers (2)

Aaron Digulla
Aaron Digulla

Reputation: 328744

Most implementations of sprintf() don't copy the format string and instead use a pointer inside the string you passed. If format and output point to the same memory, that will lead to odd results.

And you should really use snprintf() which protects you against buffer overflows.

To find all calls, put #define sprintf +++ into a common header find and recompile all sources. That should give you a list of errors along with the file name and line numbers :) Or use recursive search'n'replace of your IDE.

If you want to trim this list down to the ones where you use the same pointer for both arguments, use this macro:

#define sprintf(output,format,...) check_sprintf(__FILE__,__LINE__,output,format,....)

Note that not all compilers support macros with varargs. Then define a new function check_sprintf:

int check_sprintf (char*filename,int line,char*output,char*format,...) {
    va_list args;
    int len;

    if(output==format) {
        fprintf(stderr,
             "Output and format are the same at %s:%d", filename, line);
             abort();
    }

    va_start (args, format);
    len = vsprintf (output, format, args);
    va_end (args);

    return len;   
}

[EDIT] I just saw that you're talking about the output and the first argument. You can reuse the code from above and call va_arg() to get the first argument and use that in the compare.

Upvotes: 12

Kornel Kisielewicz
Kornel Kisielewicz

Reputation: 57575

While it is valid K&R C, you probably want to rather know if it's valid POSIX - see sprintf Specification. We read:

If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined.

Upvotes: 23

Related Questions