CODEWITHSUNDEEP
androiddatabasesqlitelistactivity
CodeFusionMobile
CodeFusionMobile

Reputation: 15100

Android SimpleCursorAdapter doesn't update when database changes

I have an Android ListActivity that is backed by a database Cursor through a SimpleCursorAdapter.

When the items are clicked, a flag field in the coresponding row in the database is toggled and the view in the list needs to be updated.

The problem is, when the view that's updated goes off screen and is recycled, the old value is displayed on the view when it returns into view. The same thing happens whenever thr list is redrawb (orientation changes, etc).

I use notifydatasetchanged() to refresh the cursor adapter but it seems ineffective.

How should I be updating the database so the cursor is updated as well?

Upvotes: 43

Views: 40642

Answers (6)

Shwarz Andrei
Shwarz Andrei

Reputation: 697

It's easy. 

private Db mDbAdapter;
private Cursor mCursor;
private SimpleCursorAdapter mCursorAd;

.....................................
//After removing the item from the DB, use this
.....................................

 mCursor = mDbAdapter.getAllItems();
 mCursorAd.swapCursor(mCursor);

Or use CursorLoader...

Upvotes: 0

Jaroslav
Jaroslav

Reputation: 263

requery() is already deprecated, just implement the simple updateUI() method like this in your CursorAdapter's child class and call it after data updates:

private void updateUI(){
    swapCursor(dbHelper.getCursor());
    notifyDataSetChanged();
}

Upvotes: 0

CommonsWare
CommonsWare

Reputation: 1006584

Call requery() on the Cursor when you change data in the database that you want reflected in that Cursor (or things the Cursor populates, like a ListView via a CursorAdapter).

A Cursor is akin to an ODBC client-side cursor -- it holds all of the data represented by the query result. Hence, just because you change the data in the database, the Cursor will not know about those changes unless you refresh it via requery().

UPDATE: This whole question and set of answers should be deleted due to old age, but that's apparently impossible. Anyone seeking Android answers should bear in mind that the Android is a swiftly-moving target, and answers from 2009 are typically worse than are newer answers.

The current solution is to obtain a fresh Cursor and use either changeCursor() or swapCursor() on the CursorAdapter to affect a data change.

Upvotes: 91

gjican
gjican

Reputation: 11

I am not clear if you set the autoRequery property of CursorAdapter to true.

The adapter will check the autoRequery property; if it is false, then the cursor will not be changed.

Upvotes: 1

siefca
siefca

Reputation: 1147

In case of using loader and automagically generated cursor you can call:

getLoaderManager().restartLoader(0, null, this);

in your activity, just after changing something on a DB, to regenerate new cursor. Don't forget to also have event handlers defined:

@Override
public Loader<Cursor> onCreateLoader(int id, Bundle args) {
    CursorLoader cursorLoader =
            new CursorLoader(this,
                    YOUR_URI,
                    YOUR_PROJECTION, null, null, null);
    return cursorLoader;
}

@Override
public void onLoadFinished(Loader<Cursor> loader, Cursor data) {
    adapter.swapCursor(data);
}

@Override
public void onLoaderReset(Loader<Cursor> loader) {
    adapter.swapCursor(null);
}

Upvotes: 21

rony l
rony l

Reputation: 6002

requery is now deprecated. from the documentation:

This method is deprecated. Don't use this. Just request a new cursor, so you can do this asynchronously and update your list view once the new cursor comes back.

after obtaining a new cursor one can use theadapter.changeCursor(cursor). this should update the view.

Upvotes: 38

Related Questions