CODEWITHSUNDEEP
javamemory-leaksgarbage-collectionjavafx-2javafx
damat-perdigannat
damat-perdigannat

Reputation: 5960

JavaFX addEventListener Memory Leak on Grand Parent

Why would the anonymous inner class not be released here, causing a memory leak? This happens for FX 2.2.1.

anchorPane.getParent().getParent().lookup("#grandParentButton").addEventFilter(KeyEvent.KEY_PRESSED, new EventHandler<KeyEvent>() {
    @Override
    public void handle(KeyEvent e) {
        if (e.getCode() == KeyCode.ENTER) {
            someButtonInsideAnchorPane.requestFocus();
            e.consume();
        }
    }
});

Why would this below on the other hand be garbage collected?

button1InsideAnchorPane.addEventFilter(KeyEvent.KEY_PRESSED, new EventHandler<KeyEvent>() {
    @Override
    public void handle(KeyEvent e) {
        if (e.getCode() == KeyCode.ENTER) {
            button2InsideAnchorPane.requestFocus();
            e.consume();
        }
    }
});

Upvotes: 1

Views: 738

Answers (2)

maaartinus
maaartinus

Reputation: 46482

The first answer is wrong. It's true that "An an inner class always holds a strong ref to its outer class", but then it goes the other way round. Actually, the outer class can't be collected as long as the inner is alive.

The reason for the instance not being collected as its registering as listener. The registrar typically holds a strong reference to the listener, so the instance can't be collected (no idea about FX).

The only explanation for the different behavior is that each object was registered with a different component. One of them has got collected and the other hasn't. No idea why, maybe one of them belonged to a dialog?

Upvotes: 1

tomsontom
tomsontom

Reputation: 5897

An an inner class always holds a strong ref to its outer class and is only gced if the outer one is not referenced any more. Make it a static inner class and you don't have the problem!

Upvotes: 1

Related Questions