CODEWITHSUNDEEP
javaexception
user2946846
user2946846

Reputation: 27

Exception handling infinite loop

my question is short and sweet. I do not understand why my program infinitely loops when catching an error. I made a fresh try-catch statement but it looped and even copied, pasted and modified the appropriate variables from a previous program that worked. Below is the statement itself and below that will be the entire program. Thank you for your help!

try {
    input = keyboard.nextInt();
}
catch(Exception e) {
    System.out.println("Error: invalid input");
again = true;

}
if (input >0 && input <=10)
    again = false;

}

Program:

    public class Blanco {

    public static int input;

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {
        // TODO code application logic here
        nameInput();



    }

    /**
     *
     * @param name
     */
    public static void nameInput() {

        System.out.println("What is the name of the cartoon character : ");
        Scanner keyboard = new Scanner(System.in);
        CartoonStar star = new CartoonStar();
        String name = keyboard.next();
        star.setName(name);
        typeInput(keyboard, star);

    }

    public static void typeInput(Scanner keyboard, CartoonStar star) {

boolean again = true;
while(again){
        System.out.println("What is the cartoon character type: 1 = FOX,2 = CHICKEN,3 = RABBIT,4 = MOUSE,5 = DOG,\n"
                + "6 = CAT,7 = BIRD,8 = FISH,9 = DUCK,10 = RAT");

try {
    input = keyboard.nextInt();
}
catch(Exception e) {
    System.out.println("Error: invalid input");
again = true;

}
if (input >0 && input <=10)
    again = false;

}


        switch (input) {
            case 1:
                star.setType(CartoonType.FOX);
                break;

            case 2:
                star.setType(CartoonType.CHICKEN);
                break;
            case 3:
                star.setType(CartoonType.RABBIT);
                break;
            case 4:
                star.setType(CartoonType.MOUSE);
                break;
            case 5:
                star.setType(CartoonType.DOG);
                break;
            case 6:
                star.setType(CartoonType.CAT);
                break;
            case 7:
                star.setType(CartoonType.BIRD);
                break;
            case 8:
                star.setType(CartoonType.FISH);
                break;
            case 9:
                star.setType(CartoonType.DUCK);
                break;
            case 10:
                star.setType(CartoonType.RAT);
                break;
        }
        popularityNumber(keyboard, star);
    }

    public static void popularityNumber(Scanner keyboard, CartoonStar star) {
        System.out.println("What is the cartoon popularity number?");
        int popularity = keyboard.nextInt();
        star.setPopularityIndex(popularity);
        System.out.println(star.getName() + star.getType() + star.getPopularityIndex());
    }

}

Upvotes: 0

Views: 3523

Answers (1)

Sergey Kalinichenko
Sergey Kalinichenko

Reputation: 727127

Your program runs forever because calling nextInt without changing the state of the scanner is going to cause an exception again and again: if the user did not enter an int, calling keyboard.nextInt() will not change what the scanner is looking at, so when you call keyboard.nextInt() in the next iteration, you'll get an exception.

You need to add some code to read the garbage the user entered after servicing an exception to fix this problem:

try {
     ...
} catch(Exception e) {
    System.out.println("Error: invalid input:" + e.getMessage());
    again = true;
    keyboard.next(); // Ignore whatever is entered
}

Note: you do not need to rely on exceptions in this situation: rather than calling nextInt(), you could call hasNextInt(), and check if the scanner is looking at an integer or not.

Upvotes: 3

Related Questions