user23
user23

Reputation: 425

Why do I need operator overloading?

need advice please. The code below, I'm simply trying to cout the x and y values stored in Line2D class. But i get this error.

Assn3.cpp:166:34: error: no match for ‘operator<<’ in ‘std::operator<< [with _Traits = std::char_traits<char>]((* & std::cout), ((const char*)"Pt1: ")) << l2d.Line2D::getPt1()’

Do I need operator overloading? if yes, why? I tried the same for other classes, no error.

Here's my code:

vector<Line2D> l2dvector;
Line2D l2d;

void readData()
{
    cout<< "Please enter filename : ";
    cin >> inputFile;

    fstream fileStream;
        fileStream.open(inputFile.c_str(),fstream::in);
        int records = 0;

    while( fileStream.good() ) 
    {
        string line = "";
        while (getline (fileStream, line))  
        {   
            stringstream ss (line);
            getline (ss, className, ',');

                 if (className == "Line2D")
            {   
                int x1, x2, y1, y2;
                getline (ss, l2dX1, '[');
                getline (ss, l2dX1, ',');

                getline (ss, l2dY1, ' ');
                getline (ss, l2dY1, ']');

                getline (ss, l2dX2, ' ');
                getline (ss, l2dX2, '[');
                getline (ss, l2dX2, ',');

                getline (ss, l2dY2, ' ');
                getline (ss, l2dY2, ']');

                istringstream (l2dX1) >> x1;
                istringstream (l2dX2) >> x2;
                istringstream (l2dY1) >> y1;
                istringstream (l2dY2) >> y2;

                Point2D pt1 (x1,y1);
                Point2D pt2 (x2,y2);

                Line2D l2d (pt1, pt2);
                l2dvector.push_back(l2d);
                l2d.setPt1(pt1);
                l2d.setPt2(pt2);

            //cout << "class name: " << className << endl;          
            cout << "Pt1: " << l2d.getPt1() << endl;
            cout << "Pt2: " << l2d.getPt2() << endl;
            }
                }

    records++;
    }

    cout << records << "records read in successfully!" << endl;
    cout << "Going back to main menu .. " << endl;

}




Line2D.cpp

Line2D::Line2D ()
{

}

Line2D::Line2D (Point2D pt1, Point2D pt2)
{
    this->pt1 = pt1;
    this->pt2 = pt2;
}


double Line2D::setLength()
{
    length = sqrt(pow((pt1.getX()-pt2.getX()),2)) + pow ((pt1.getY()-pt2.getY()),2);
    return length;
}


//Accessors

Point2D Line2D::getPt1()
{
    return pt1;
}


Point2D Line2D::getPt2()
{
    return pt2;
}

double Line2D::getScalarValue() //returns the value of attribute length
{
    return length;
}


//Mutators

void Line2D::setPt1 (Point2D pt1)
{
    this->pt1 = pt1;
}

void Line2D::setPt2 (Point2D pt2)
{
    this->pt2 = pt2;
}

Edit:

Added operator overloading in Point2D.h

ostream &operator<<( ostream &output, const Point2D &P)
              { 
             output << "X : " << P.x << " Y : " << P.y;
             return output;            
              }

Error compiling:

In file included from Point2D.cpp:3:0:
Point2D.h:39:60: error: ‘std::ostream& Point2D::operator<<(std::ostream&, const Point2D&)’ must take exactly one argument
In file included from Point3D.h:9:0,
                 from Point3D.cpp:3:
Point2D.h:39:60: error: ‘std::ostream& Point2D::operator<<(std::ostream&, const Point2D&)’ must take exactly one argument
In file included from Line2D.h:9:0,
                 from Line2D.cpp:3:
Point2D.h:39:60: error: ‘std::ostream& Point2D::operator<<(std::ostream&, const Point2D&)’ must take exactly one argument

Upvotes: 1

Views: 2356

Answers (3)

Santosh Sahu
Santosh Sahu

Reputation: 2244

We need to provide operator overloading of >> and << operator if you want to print and take input of user defined objects..

g++ library had overloaded << and >> operator for basic built-in data types. g++ compiler doesn't provide default << and >> operator functions unlike = operator overloaded function.

Here your object Point2D is not known to g++ compiler, or the signatures doesn't match, hence it is giving that error.

Upvotes: 0

Brian Gradin
Brian Gradin

Reputation: 2275

The stream operators operator<< and operator>> are called whenever an object is outputted to or inputted from a stream, respectively. So if a class doesn't define one of these, the functionality attributed to it will be inaccessible.

So basically, long story short, your Point2D class needs an operator<<. If you wanted to use it with cin, it would also need an operator>>.

Here is a tutorial on overloading the stream operators.

Upvotes: 6

Abhishek Bansal
Abhishek Bansal

Reputation: 12715

Your getPt1() and getPt2() return a Point2D. You need to instruct the compiler what to output when a Point2D is outputted.

Hence you will need to overload the operator << so that the compiler understands what you mean when you say "output the value of Point2D".

Upvotes: 1

Related Questions