CODEWITHSUNDEEP
c#if-statement
Dr.Vista
Dr.Vista

Reputation: 139

if else if doesn't continue till the end

i'm working on win form application deals with XML files

i added this code to the form load event 

if (!File.Exists("clients.xml"))
            {
                List<string> lines = new List<string>();
                lines.Add("<clients>");
                lines.Add("</clients>");
                File.WriteAllLines("clients.xml", lines);
            }
            else if (!File.Exists("cases.xml"))
            {
                List<string> lines = new List<string>();
                lines.Add("<names>");
                lines.Add("</names>");
                File.WriteAllLines("cases.xml", lines);
            }
            else if (!File.Exists("files.xml"))
            {
                List<string> lines = new List<string>();
                lines.Add("<num>");
                lines.Add("</num>");
                File.WriteAllLines("files.xml", lines);
            }

when i start my application if none of these three files exists it only creates the first file!!

if the first file only exists it creates only the second file !!

if both exists then it creates the third one..

any idea what is wrong with this code?!!

thanks ...

Upvotes: 0

Views: 103

Answers (3)

now he who must not be named.
now he who must not be named.

Reputation: 9396

Do not do by the way you are doing:

Rule of thumb: Do not repeat the code

Write a generic function like this:

public void DoStuff(string fileName, List<string> linesToBeWritten)
{
   var output = new List<string>();

   if (!File.Exists(fileName))
    return;

   output.Add("<" + fileName + ">");
   output.AddRange(linesToBeWritten); 
   output.Add("</" + fileName + ">");

   File.WriteAllLines(fileName, output);
}

Upvotes: 2

David Pilkington
David Pilkington

Reputation: 13630

Remove the else from the else if.

This means that all of the if statements will be evaluated.

The way that you have it set up, it has a waterfall effect. If the first statement is false, evaluate the second. If that is false evaluate the third etc.

Upvotes: 3

Sudhakar Tillapudi
Sudhakar Tillapudi

Reputation: 26209

Solution : use if instead of else-if .

Reason : if you use combination of if-else it only executes first true scenario and skips the further.
but if you use if for all conditions it will execute all true scenarios.

Code:

                if (!File.Exists("clients.xml"))
                {
                    List<string> lines = new List<string>();
                    lines.Add("<clients>");
                    lines.Add("</clients>");
                    File.WriteAllLines("clients.xml", lines);
                }
                 if (!File.Exists("cases.xml"))
                {
                    List<string> lines = new List<string>();
                    lines.Add("<names>");
                    lines.Add("</names>");
                    File.WriteAllLines("cases.xml", lines);
                }
                if (!File.Exists("files.xml"))
                {
                    List<string> lines = new List<string>();
                    lines.Add("<num>");
                    lines.Add("</num>");
                    File.WriteAllLines("files.xml", lines);
                }
                else
                {
                    return;
                }

Upvotes: 4

Related Questions