CODEWITHSUNDEEP
javascriptregex
Otis Eugene Anderson
Otis Eugene Anderson

Reputation: 35

Regex not matching properly

Ive been working on this regex for days now and I cant get it figured out. It either passes everything I put in there or it kicks everything out and I cannot seem to make it function. Admittedly I am new to doing this complex of stuff with Javascript so It may be that you realy cant do this.

I want to check onkeypress what was entered into the input and then validate it to x, y, or z. Then from there send it on about its way to do other neat stuff.

So the question is what the heck am I not understanding about RegExp?

Here is a FIDDLE for it.

    function val() {
    var gradeIn = document.querySelectorAll("#letGrade input[type=text]");
    var checkGrade = new RegExp(/[xyz]/gi);
    for (var i = 0; i < gradeIn.length; i++) {
        if (!checkGrade.test(gradeIn.value)) {
            alert ("This must be X, Y, or Z");
            return false;
        } else {
            return true;
        }
    }
};

EDIT/UPDATE: I was trying to do this on keypress and validate each text input individualy however this was realy kinda squishy in the grand scheme of things and not working out exactly correct. I decided to validate all text inputs onsubmit and have everything go all at once. Updated code is below.

function calcGPA() {
    var grades = document.querySelectorAll("#letGrade input[type=text]");
    var contacts = document.querySelectorAll("#conHours input[type=text]");
    var gVals = [];
    var cVals = [];
    var failGrade = "The Letter Grade input may only be A, B, C, D or F";
    var failHours = "The Contact Hours input may only be 1, 2, 3, 4 or 5";
    var checkGrade = /^[ABCDF]/;
    var checkhours = /^[12345]/;

    for (var i = 0; i < grades.length; i++) {
        if (!checkGrade.test(grades[i].value)) {
            alert(failGrade);
            return false;
        }
        if (!checkhours.test(contacts[i].value)) {
            alert(failHours);
            return false;
        }
        gVals.push(grades[i].value);
        cVals.push(contacts[i].value);
    }
    //Other cool stuff happens here
};

Now to just finish the conversion piece for the letters to numbers and the math piece. Thank you for your help on this!

Upvotes: 1

Views: 90

Answers (1)

Pointy
Pointy

Reputation: 413702

The problem's not only with your regular expression.

if (!checkGrade.test(gradeIn[i].value)) {

You weren't checking each grade. Now if you want it to only be those characters, you have to extend the regular expression a bit. Also, there's no point calling new RegExp if you're using native syntax.

var checkGrade = /^[xyz]+$/;

That means that you're OK with the fields being like "xxyyz" or "zzy". If it should just be one character, that'd be

var checkGrade = /^[xyz]$/;

Upvotes: 2

Related Questions