Populating table data with javafx using fxml

Question

It has been so difficult for me to try and get an answer for this. Oracle doesn't document on their website for some reason?! It has been asked on stackoverflow already (JavaFX: TableView(fxml) filling with data, and JavaFX FXML table; why won't my data display), but when i try to recreate with the answers given, I am still unable to get it to work. I would be extremely grateful if someone would be able to help! I'll give out all the code of have put together.

public class Heroes extends Application {

    public static void main(String[] args) {
        launch(args);
    }

    @Override
    public void start(Stage primaryStage) throws Exception {
        try {
            AnchorPane page = FXMLLoader.load(Heroes.class.getResource("FXMLDocument.fxml"));

            Scene scene = new Scene(page);
            primaryStage.setScene(scene);
            primaryStage.setTitle("Sample Window"); 
            primaryStage.setResizable(false); 
            primaryStage.show();
        } catch (Exception e) {
        }
    }
}

public class FXMLDocumentController implements Initializable {

    /**
     * Initializes the controller class.
     */
    @FXML
    TableView tableID;
    @FXML
    TableColumn tID;
    @FXML
    TableColumn tName;
    @FXML
    TableColumn tDate;
    @FXML
    TableColumn tPrice;
    int iNumber = 1;
    ObservableList data =
            FXCollections.observableArrayList(
            new Table(iNumber++, "Superman", "12/02/2013", "20"),
            new Table(iNumber++, "Batman", "2/02/2013", "40"),
            new Table(iNumber++, "Aquaman", "1/02/2013", "100"),
            new Table(iNumber++, "The Flash", "12/02/2013", "16"));

    @Override
    public void initialize(URL url, ResourceBundle rb) {
        // System.out.println("called");

        tID.setCellValueFactory(new PropertyValueFactory("rID"));
        tName.setCellValueFactory(new PropertyValueFactory("rName"));
        tDate.setCellValueFactory(new PropertyValueFactory("rDate"));
        tPrice.setCellValueFactory(new PropertyValueFactory("rPrice"));
        tableID.setItems(data);

    }
}

public class Table {

    SimpleIntegerProperty rID;
    SimpleStringProperty rName;
    SimpleStringProperty rDate;
    SimpleStringProperty rPrice;

    public Table(int rID, String rName, String rDate, String rPrice) {
        this.rID = new SimpleIntegerProperty(rID);
        this.rName = new SimpleStringProperty(rName);
        this.rDate = new SimpleStringProperty(rDate);
        this.rPrice = new SimpleStringProperty(rPrice);
        System.out.println(rID);
        System.out.println(rName);
        System.out.println(rDate);
        System.out.println(rPrice);
    } 

    public Integer getrID() {
        return rID.get();
    }

    public void setrID(Integer v) {
        this.rID.set(v);
    }

    public String getrDate() {
        return rDate.get();
    }

    public void setrDate(String d) {
        this.rDate.set(d);
    }

    public String getrName() {
        return rName.get();
    }

    public void setrName(String n) {
         this.rDate.set(n);
    }

    public String getrPrice() {
        return rPrice.get();
    }

    public void setrPrice(String p) {
       this.rPrice.set(p); 
    }
}

Knut Arne Vedaa · Accepted Answer

The PropertyValueFactory tries to find your data values in two ways:

1) Looking for a method e.g. nameProperty where name is what you specify in the constructor, in your example e.g. "rID".

Thus you need to a methods named like this (name of the field + "Property"):

public IntegerProperty rIDProperty() {
    return rID;
}

And similar for your other properties.

2) If these aren't present, it looks for methods named e.g. getName where Name is what you specifiy in the constructor with the first letter capitalized (following the Java Beans convention).

In your example you don't have 1) but you seem to have 2) - but you haven't capitalized the first letter of the property name in the getters and setters!

So change these to e.g.

public Integer getRID() {
    return rID.get();
}

And similar.

You need either 1) or 2) but it would be good practice to have both.

Also note that the problem is not related to FXML in any way.

Populating table data with javafx using fxml

Answers (1)

Related Questions