CODEWITHSUNDEEP
sqlsql-servertimeoutmax
simonl
simonl

Reputation: 183

SELECT MAX() too slow - any alternatives?

I've inherited a SQL Server based application and it has a stored procedure that contains the following, but it hits timeout. I believe I've isolated the issue to the SELECT MAX() part, but I can't figure out how to use alternatives, such as ROW_NUMBER() OVER( PARTITION BY...

Anyone got any ideas?

Here's the "offending" code:

SELECT BData.*, B.* 
FROM BData
INNER JOIN
(
    SELECT MAX( BData.StatusTime ) AS MaxDate, BData.BID
    FROM BData
    GROUP BY BData.BID
) qryMaxDates
ON ( BData.BID = qryMaxDates.BID ) AND ( BData.StatusTime = qryMaxDates.MaxDate )
INNER JOIN BItems B ON B.InternalID = qryMaxDates.BID
WHERE  B.ICID = 2
ORDER BY BData.StatusTime DESC;

Thanks in advance.

Upvotes: 8

Views: 33030

Answers (6)

Aaron Bertrand
Aaron Bertrand

Reputation: 280351

Consider creating the following index:

CREATE INDEX LatestTime ON dbo.BData(BID, StatusTime DESC);

This will support a query with a CTE such as:

;WITH x AS
(
  SELECT *, rn = ROW_NUMBER() OVER (PARTITION BY BID ORDER BY StatusDate DESC)
  FROM dbo.BData
)
SELECT * FROM x 
INNER JOIN dbo.BItems AS bi
  ON x.BID = bi.InternalID
WHERE x.rn = 1 AND bi.ICID = 2
ORDER BY x.StatusDate DESC;

Whether the query still gets efficiencies from any indexes on BItems is another issue, but this should at least make the aggregate a simpler operation (though it will still require a lookup to get the rest of the columns).

Another idea would be to stop using SELECT * from both tables and only select the columns you actually need. If you really need all of the columns from both tables (this is rare, especially with a join), then you'll want to have covering indexes on both sides to prevent lookups.

I also suggest calling any identifier the same thing throughout the model. Why is the ID that links these tables called BID in one table and InternalID in another?

Also please always reference tables using their schema.

Upvotes: 6

user3520211
user3520211

Reputation: 59

This may be a late response, but I recently ran into the same performance issue where a simple query involving max() is taking more than 1 hour to execute.

After looking at the execution plan, it seems in order to perform the max() function, every record meeting the where clause condition will be fetched. In your case, it's every record in your table will need to be fetched before performing max() function. Also, indexing the BData.StatusTime will not speed up the query. Indexing is useful for looking up a particular record, but it will not help performing comparison.

In my case, I didn't have the group by so all I did was using the ORDER BY DESC clause and SELECT TOP 1. The query went from over 1 hour down to under 5 minutes. Perhaps, you can do what Gordon Linoff suggested and use PARTITION BY. Hopefully, your query can speed up.

Cheers!

Upvotes: 5

simonl
simonl

Reputation: 183

[UNSOLVED] But I've moved on!

Thanks to everyone who provided answers / suggestions. Unfortunately I couldn't get any further with this, so have given-up trying for now.

It looks like the best solution is to re-write the application to UPDATE the latest data into into a different table, that way it's a really quick and simple SELECT to latest readings.

Thanks again for the suggestions.

Upvotes: 1

Remus Rusanu
Remus Rusanu

Reputation: 294307

SQL performance problems are seldom addressed by rewriting the query. The compiler already know how to rewrite it anyway. The problem is always indexing. To get MAX(StatusTime ) ... GROUP BY BID efficiently, you need an index on BData(BID, StatusTime). For efficient seek of WHERE B.ICID = 2 you need an index on BItems.ICID.

The query could also be, probably, expressed as a correlated APPLY, because it seems that what is what's really desired:

SELECT D.*, B.* 
FROM BItems B
CROSS APPLY
(
    SELECT TOP(1) *
    FROM BData
    WHERE B.InternalID = BData.BID
    ORDER BY StatusTime DESC
) AS D
WHERE  B.ICID = 2
ORDER BY D.StatusTime DESC;

SQL Fiddle.

This is not semantically the same query as OP, the OP would return multiple rows on StatusTime collision, I just have a guess though that this is what is desired ('the most recent BData for this BItem').

Upvotes: 6

Kahn
Kahn

Reputation: 1660

Depends entirely on what kind of data you have there. One alternative that may be faster is using CROSS APPLY instead of the MAX subquery. But more than likely it won't yield any faster results.

The best option would probably be to add an index on BID, with INCLUDE containing the StatusTime, and if possible filtering that by InternalID's matching BItems.ICID = 2.

Upvotes: 1

Gordon Linoff
Gordon Linoff

Reputation: 1269973

The following is the version of your query using row_number():

SELECT bd.*, b.* 
FROM (select bd.*, row_number() over (partition by bid order by statustime desc) as seqnum
      from BData bd
     ) bd INNER JOIN
     BItems b
     ON b.InternalID = bd.BID and bd.seqnum = 1
WHERE B.ICID = 2
ORDER BY BData.StatusTime DESC;

If this is not faster, then it would be useful to see the query plans for your query and this query to figure out how to optimize them.

Upvotes: 1

Related Questions